[PR #1821] [MERGED] fix: documents failing to seal #1868

New issue

Closed

opened 2026-02-26 20:31:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1821
Author: @Mythie
Created: 6/4/2025
Status: ✅ Merged
Merged: 6/4/2025
Merged by: @Mythie

Base: main ← Head: fix/documents-failing-to-seal

📝 Commits (1)

68a8bdc fix: documents failing to seal

📊 Changes

4 files changed (+48 additions, -47 deletions)

View changed files

📝 docker/development/compose.yml (+0 -37)
📝 packages/lib/server-only/document/seal-document.ts (+2 -2)
📝 packages/lib/server-only/pdf/flatten-form.ts (+13 -2)
📝 packages/lib/server-only/pdf/insert-field-in-pdf.ts (+33 -6)

📄 Description

During our field rework that makes fields appear
more accurately between signing and the completed pdf we swapped to using text fields. Unfortunately as part of that we dropped using the Noto font for the text field causing ANSI encoding issues when encountering certain characters.

This change restores the font and handles a nasty issue we had with our form flattening reverting our selected font.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1821 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 6/4/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/documents-failing-to-seal` --- ### 📝 Commits (1) - [`68a8bdc`](https://github.com/documenso/documenso/commit/68a8bdccdccbb0429b3d3309e94d0dd6be610cef) fix: documents failing to seal ### 📊 Changes **4 files changed** (+48 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `docker/development/compose.yml` (+0 -37) 📝 `packages/lib/server-only/document/seal-document.ts` (+2 -2) 📝 `packages/lib/server-only/pdf/flatten-form.ts` (+13 -2) 📝 `packages/lib/server-only/pdf/insert-field-in-pdf.ts` (+33 -6) </details> ### 📄 Description During our field rework that makes fields appear more accurately between signing and the completed pdf we swapped to using text fields. Unfortunately as part of that we dropped using the Noto font for the text field causing ANSI encoding issues when encountering certain characters. This change restores the font and handles a nasty issue we had with our form flattening reverting our selected font. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:26 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:34 +03:00

[PR #1868] [CLOSED] Chore/disclosure text #1898

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1868

No description provided.

Rows
Columns