[PR #1758] [CLOSED] feat: complete document 2fa #1833

New issue

Closed

opened 2026-02-26 20:31:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1758
Author: @ephraimduncan
Created: 4/23/2025
Status: ❌ Closed

Base: main ← Head: feat/document-2fa

📝 Commits (9)

35db818 feat: complete document 2fa (wip)
3bf056a fix: build errors
7a3763b refactor: refine document 2FA components
d487050 feat: email verification for document signing 2FA
30a4f2c feat: resend email countdown
311adb4 chore: refactor
eb2b9dd chore: update tests
c4cb6ee chore: minor updates
4fc4a8b fix: merge conflicts

📊 Changes

26 files changed (+786 additions, -204 deletions)

View changed files

📝 apps/remix/app/components/general/document-signing/document-signing-auth-2fa.tsx (+219 -66)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-dialog.tsx (+16 -3)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-provider.tsx (+14 -3)
📝 apps/remix/app/components/general/document-signing/document-signing-form.tsx (+24 -5)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view.tsx (+3 -0)
📝 apps/remix/app/components/general/template/template-edit-form.tsx (+1 -1)
📝 apps/remix/app/routes/_recipient+/d.$token+/_index.tsx (+1 -0)
📝 apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx (+10 -0)
📝 apps/remix/app/routes/embed+/_v0+/direct.$url.tsx (+1 -0)
📝 apps/remix/app/routes/embed+/_v0+/sign.$url.tsx (+1 -0)
📝 packages/app-tests/e2e/document-flow/settings-step.spec.ts (+6 -6)
📝 packages/app-tests/e2e/templates-flow/template-settings-step.spec.ts (+4 -4)
➕ packages/email/template-components/template-verification-code.tsx (+43 -0)
➕ packages/email/templates/verification-code.tsx (+62 -0)
➕ packages/lib/server-only/2fa/send-email-verification.ts (+120 -0)
📝 packages/lib/server-only/document/update-document.ts (+1 -19)
📝 packages/lib/server-only/field/sign-field-with-token.ts (+23 -10)
📝 packages/lib/server-only/template/update-template.ts (+7 -2)
📝 packages/lib/types/document-auth.ts (+14 -0)
➕ packages/prisma/migrations/20250430202737_add_email_migration/migration.sql (+12 -0)

...and 6 more files

📄 Description

Demo

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1758 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 4/23/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/document-2fa` --- ### 📝 Commits (9) - [`35db818`](https://github.com/documenso/documenso/commit/35db8182f0f192537e5ca1c08860568eeba877e7) feat: complete document 2fa (wip) - [`3bf056a`](https://github.com/documenso/documenso/commit/3bf056aa437b92858b8763a7b5834f27ad437c30) fix: build errors - [`7a3763b`](https://github.com/documenso/documenso/commit/7a3763bb66f68db799b7959b6d42a182bfd03609) refactor: refine document 2FA components - [`d487050`](https://github.com/documenso/documenso/commit/d48705024e425cd065445effa514b4655df62be9) feat: email verification for document signing 2FA - [`30a4f2c`](https://github.com/documenso/documenso/commit/30a4f2c7b4b28235fcf795d59936908e9bab4cc7) feat: resend email countdown - [`311adb4`](https://github.com/documenso/documenso/commit/311adb4d1e0cc49c8729df21695ee602acaa187c) chore: refactor - [`eb2b9dd`](https://github.com/documenso/documenso/commit/eb2b9dd09900953ce85891a922db3195c3e52c17) chore: update tests - [`c4cb6ee`](https://github.com/documenso/documenso/commit/c4cb6eeb94e0c6996f0471baac7bd442bf6318cf) chore: minor updates - [`4fc4a8b`](https://github.com/documenso/documenso/commit/4fc4a8ba7f1cb4b58eeebdd795f8d7137b5f45fb) fix: merge conflicts ### 📊 Changes **26 files changed** (+786 additions, -204 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-2fa.tsx` (+219 -66) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-dialog.tsx` (+16 -3) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-provider.tsx` (+14 -3) 📝 `apps/remix/app/components/general/document-signing/document-signing-form.tsx` (+24 -5) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view.tsx` (+3 -0) 📝 `apps/remix/app/components/general/template/template-edit-form.tsx` (+1 -1) 📝 `apps/remix/app/routes/_recipient+/d.$token+/_index.tsx` (+1 -0) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx` (+10 -0) 📝 `apps/remix/app/routes/embed+/_v0+/direct.$url.tsx` (+1 -0) 📝 `apps/remix/app/routes/embed+/_v0+/sign.$url.tsx` (+1 -0) 📝 `packages/app-tests/e2e/document-flow/settings-step.spec.ts` (+6 -6) 📝 `packages/app-tests/e2e/templates-flow/template-settings-step.spec.ts` (+4 -4) ➕ `packages/email/template-components/template-verification-code.tsx` (+43 -0) ➕ `packages/email/templates/verification-code.tsx` (+62 -0) ➕ `packages/lib/server-only/2fa/send-email-verification.ts` (+120 -0) 📝 `packages/lib/server-only/document/update-document.ts` (+1 -19) 📝 `packages/lib/server-only/field/sign-field-with-token.ts` (+23 -10) 📝 `packages/lib/server-only/template/update-template.ts` (+7 -2) 📝 `packages/lib/types/document-auth.ts` (+14 -0) ➕ `packages/prisma/migrations/20250430202737_add_email_migration/migration.sql` (+12 -0) _...and 6 more files_ </details> ### 📄 Description ## Demo ### Document and Template Setting https://github.com/user-attachments/assets/75c647bb-0ae6-4222-b836-ecebadab383e ### Emailing a given 2FA Token if a user does not have a 2FA secret created https://github.com/user-attachments/assets/45fb53d5-dcd1-481d-bd69-3b90479cd81e ### Emailing a given 2FA Token if a user has a 2FA secret created https://github.com/user-attachments/assets/b981b279-b960-4df9-b74a-70a0b0c83832 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:16 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1833

No description provided.

Rows
Columns