[PR #1753] [MERGED] fix: signing volume query #1827

New issue

Closed

opened 2026-02-26 20:31:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1753
Author: @ephraimduncan
Created: 4/18/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @Mythie

Base: main ← Head: fix/leaderboard-query-remix

📝 Commits (1)

bb5fb8c fix: signing volume query

📊 Changes

3 files changed (+200 additions, -90 deletions)

View changed files

📝 apps/remix/app/components/tables/admin-leaderboard-table.tsx (+4 -0)
📝 apps/remix/app/routes/_authenticated+/admin+/leaderboard.tsx (+17 -6)
📝 packages/lib/server-only/admin/get-signing-volume.ts (+179 -84)

📄 Description

Description

This pull request updates the implementation of the admin leaderboard, enhancing data handling and improving type safety. It introduces clearer differentiation between users and teams, adds additional fields to track more relevant information, and refactors the querying logic to optimize performance and maintainability.

Changes Made

Refactored getSigningVolume from a Kysely query to Prisma ORM for improved readability and consistency.
Implemented logic to distinguish between team and user subscriptions, aggregating their respective document counts accurately.
Added sorting and pagination logic with clearer variable naming and improved data validation.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1753 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 4/18/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/leaderboard-query-remix` --- ### 📝 Commits (1) - [`bb5fb8c`](https://github.com/documenso/documenso/commit/bb5fb8c7d45fd0f56bbaa6f167f4f38ef969c78f) fix: signing volume query ### 📊 Changes **3 files changed** (+200 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/tables/admin-leaderboard-table.tsx` (+4 -0) 📝 `apps/remix/app/routes/_authenticated+/admin+/leaderboard.tsx` (+17 -6) 📝 `packages/lib/server-only/admin/get-signing-volume.ts` (+179 -84) </details> ### 📄 Description ## Description This pull request updates the implementation of the admin leaderboard, enhancing data handling and improving type safety. It introduces clearer differentiation between users and teams, adds additional fields to track more relevant information, and refactors the querying logic to optimize performance and maintainability. ## Changes Made - Refactored `getSigningVolume` from a Kysely query to Prisma ORM for improved readability and consistency. - Implemented logic to distinguish between team and user subscriptions, aggregating their respective document counts accurately. - Added sorting and pagination logic with clearer variable naming and improved data validation. ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:14 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:27 +03:00

[PR #1827] [MERGED] feat: password reauthentication for documents and recipients #1873

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1827

No description provided.

Rows
Columns