[PR #1747] [CLOSED] feat: signing reminder #1822

Closed
opened 2026-02-26 20:31:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1747
Author: @ephraimduncan
Created: 4/14/2025
Status: Closed

Base: mainHead: feat/signing-reminder


📝 Commits (3)

  • 8b771d3 feat: add cron job trigger for background jobs
  • 9fc5ec1 feat: add reminder to advanced settings
  • f532c97 feat: add signing reminder

📊 Changes

25 files changed (+446 additions, -45 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx (+2 -1)
📝 packages/lib/jobs/client.ts (+2 -0)
📝 packages/lib/jobs/client/_internal/job.ts (+14 -4)
📝 packages/lib/jobs/client/inngest.ts (+51 -23)
📝 packages/lib/jobs/client/trigger.ts (+25 -11)
📝 packages/lib/jobs/definitions/emails/send-confirmation-email.ts (+1 -0)
📝 packages/lib/jobs/definitions/emails/send-rejection-emails.ts (+1 -0)
📝 packages/lib/jobs/definitions/emails/send-signing-email.ts (+1 -0)
packages/lib/jobs/definitions/emails/send-signing-reminder-email.ts (+169 -0)
📝 packages/lib/jobs/definitions/emails/send-team-deleted-email.ts (+1 -0)
📝 packages/lib/jobs/definitions/emails/send-team-member-joined-email.ts (+1 -0)
📝 packages/lib/jobs/definitions/emails/send-team-member-left-email.ts (+1 -0)
📝 packages/lib/jobs/definitions/internal/seal-document.ts (+1 -0)
📝 packages/lib/server-only/document-meta/upsert-document-meta.ts (+10 -2)
📝 packages/lib/server-only/document/complete-document-with-token.ts (+5 -1)
📝 packages/lib/server-only/document/send-document.tsx (+11 -1)
packages/lib/utils/should-send-reminder.ts (+49 -0)
packages/prisma/migrations/20241120202053_add_reminder_days_to_document_meta/migration.sql (+2 -0)
packages/prisma/migrations/20241121001411_add_reminder_interval_enum/migration.sql (+12 -0)
packages/prisma/migrations/20241121112709_add_last_reminder_sent_date/migration.sql (+2 -0)

...and 5 more files

📄 Description


name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Changes Made

  • Change 1
  • Change 2
  • ...

Testing Performed

  • Tested feature X in scenario Y.
  • Ran unit tests for component Z.
  • Tested on browsers A, B, and C.
  • ...

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1747 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 4/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/signing-reminder` --- ### 📝 Commits (3) - [`8b771d3`](https://github.com/documenso/documenso/commit/8b771d36d264acf0ae64fd0774aa57403ab20116) feat: add cron job trigger for background jobs - [`9fc5ec1`](https://github.com/documenso/documenso/commit/9fc5ec11f4e624a537990a28e86ce11d47ce8f5f) feat: add reminder to advanced settings - [`f532c97`](https://github.com/documenso/documenso/commit/f532c97499307d647b0cb15927a25cccf8da3e71) feat: add signing reminder ### 📊 Changes **25 files changed** (+446 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx` (+2 -1) 📝 `packages/lib/jobs/client.ts` (+2 -0) 📝 `packages/lib/jobs/client/_internal/job.ts` (+14 -4) 📝 `packages/lib/jobs/client/inngest.ts` (+51 -23) 📝 `packages/lib/jobs/client/trigger.ts` (+25 -11) 📝 `packages/lib/jobs/definitions/emails/send-confirmation-email.ts` (+1 -0) 📝 `packages/lib/jobs/definitions/emails/send-rejection-emails.ts` (+1 -0) 📝 `packages/lib/jobs/definitions/emails/send-signing-email.ts` (+1 -0) ➕ `packages/lib/jobs/definitions/emails/send-signing-reminder-email.ts` (+169 -0) 📝 `packages/lib/jobs/definitions/emails/send-team-deleted-email.ts` (+1 -0) 📝 `packages/lib/jobs/definitions/emails/send-team-member-joined-email.ts` (+1 -0) 📝 `packages/lib/jobs/definitions/emails/send-team-member-left-email.ts` (+1 -0) 📝 `packages/lib/jobs/definitions/internal/seal-document.ts` (+1 -0) 📝 `packages/lib/server-only/document-meta/upsert-document-meta.ts` (+10 -2) 📝 `packages/lib/server-only/document/complete-document-with-token.ts` (+5 -1) 📝 `packages/lib/server-only/document/send-document.tsx` (+11 -1) ➕ `packages/lib/utils/should-send-reminder.ts` (+49 -0) ➕ `packages/prisma/migrations/20241120202053_add_reminder_days_to_document_meta/migration.sql` (+2 -0) ➕ `packages/prisma/migrations/20241121001411_add_reminder_interval_enum/migration.sql` (+12 -0) ➕ `packages/prisma/migrations/20241121112709_add_last_reminder_sent_date/migration.sql` (+2 -0) _...and 5 more files_ </details> ### 📄 Description --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description <!--- Describe the changes introduced by this pull request. --> <!--- Explain what problem it solves or what feature/fix it adds. --> ## Related Issue <!--- If this pull request is related to a specific issue, reference it here using #issue_number. --> <!--- For example, "Fixes #123" or "Addresses #456". --> ## Changes Made <!--- Provide a summary of the changes made in this pull request. --> <!--- Include any relevant technical details or architecture changes. --> - Change 1 - Change 2 - ... ## Testing Performed <!--- Describe the testing that you have performed to validate these changes. --> <!--- Include information about test cases, testing environments, and results. --> - Tested feature X in scenario Y. - Ran unit tests for component Z. - Tested on browsers A, B, and C. - ... ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <!--- Provide any additional context or notes for the reviewers. --> <!--- This might include details about design decisions, potential concerns, or anything else relevant. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:31:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1822
No description provided.