starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-24 21:36:01 +03:00

[PR #1737] [MERGED] fix: pass document meta to readonly field component #1820

New issue

Closed

opened 2026-02-26 20:31:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1737
Author: @Mythie
Created: 3/31/2025
Status: ✅ Merged
Merged: 3/31/2025
Merged by: @Mythie

Base: main ← Head: fix/pass-document-meta-to-readonly-component

📝 Commits (1)

212d3f6 fix: pass document meta to readonly field component

📊 Changes

5 files changed (+20 additions, -4 deletions)

View changed files

📝 apps/remix/app/components/embed/embed-document-signing-page.tsx (+10 -0)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view.tsx (+1 -1)
📝 apps/remix/app/components/general/document/document-read-only-fields.tsx (+2 -2)
📝 apps/remix/app/routes/embed+/sign.$url.tsx (+6 -1)
📝 apps/remix/app/types/embed-document-sign-schema.ts (+1 -0)

📄 Description

Description

Previously we weren't passing the DocumentMeta to our readonly field component which is used for displaying completed fields by other recipients.

Due to this dates that were not using the default format were displaying as invalid date adding confusion to the signing process.

Reported via support email.

Changes Made

Pass the document meta to the readonly field component.
Support showing completed fields within the embedding UI.

Testing Performed

Manual testing

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1737 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/pass-document-meta-to-readonly-component` --- ### 📝 Commits (1) - [`212d3f6`](https://github.com/documenso/documenso/commit/212d3f65fa35e1d08b6c0bbadf219981b4363818) fix: pass document meta to readonly field component ### 📊 Changes **5 files changed** (+20 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/embed/embed-document-signing-page.tsx` (+10 -0) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view.tsx` (+1 -1) 📝 `apps/remix/app/components/general/document/document-read-only-fields.tsx` (+2 -2) 📝 `apps/remix/app/routes/embed+/sign.$url.tsx` (+6 -1) 📝 `apps/remix/app/types/embed-document-sign-schema.ts` (+1 -0) </details> ### 📄 Description ## Description Previously we weren't passing the DocumentMeta to our readonly field component which is used for displaying completed fields by other recipients. Due to this dates that were not using the default format were displaying as invalid date adding confusion to the signing process. ## Related Issue Reported via support email. ## Changes Made - Pass the document meta to the readonly field component. - Support showing completed fields within the embedding UI. ## Testing Performed - Manual testing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:12 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:26 +03:00

[PR #1820] [MERGED] feat: add organisations #1870

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1820

No description provided.

Rows
Columns