[PR #1730] [MERGED] fix: dynamic route for team transfer #1816

Closed
opened 2026-02-26 20:31:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1730
Author: @RefRexi
Created: 3/28/2025
Status: Merged
Merged: 4/15/2025
Merged by: @Mythie

Base: mainHead: main


📝 Commits (2)

  • 5ca25e6 Rename team.verify.transfer.token.tsx to team.verify.transfer.$token.tsx
  • d38a12c Merge branch 'main' into main

📊 Changes

1 file changed (+0 additions, -0 deletions)

View changed files

📝 apps/remix/app/routes/_unauthenticated+/team.verify.transfer.$token.tsx (+0 -0)

📄 Description

fix: dynamic route handling for /team/verify/transfer/:token


name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Renamed team.verify.transfer.token.tsx to team.verify.transfer.$token.tsx
in apps/remix/app/routes/_unauthenticated+/

Team transfer links sent via mail e.g.:

https://server.domain/team/verify/transfer/u6t-gx4ryxDYALvFKuVdidSWXXzh9nfH

Threw errors in the log:

Error: No route matches URL "/team/verify/transfer/u6t-gx4ryxDYALvFKuVdidSWXXzh9nfH"
    at getInternalRouterError (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:3776:5)
    at Object.query (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:2606:19)
    at handleDocumentRequest (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:9157:35)
    at requestHandler (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:9074:24)
    at file:///srv/documenso/node_modules/hono-react-router-adapter/dist/handlers/node/index.js:22:18
    at file:///srv/documenso/node_modules/hono-react-router-adapter/dist/handlers/node/index.js:45:7
    at dispatch (file:///srv/documenso/node_modules/hono/dist/compose.js:30:23)
    at file:///srv/documenso/node_modules/hono/dist/compose.js:31:20
    at file:///srv/documenso/node_modules/@hono/node-server/dist/serve-static.mjs:76:14
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
No routes matched location "/team/verify/transfer/u6t-gx4ryxDYALvFKuVdidSWXXzh9nfH"

and thus the transfer could not be completed.

Changes Made

Renamed team.verify.transfer.token.tsx to team.verify.transfer.$token.tsx
in apps/remix/app/routes/_unauthenticated+/

Testing Performed

Team transfer accept links work after the fix.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1730 **Author:** [@RefRexi](https://github.com/RefRexi) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 4/15/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`5ca25e6`](https://github.com/documenso/documenso/commit/5ca25e61d0b44e264d116b049ab222b4479ff92a) Rename team.verify.transfer.token.tsx to team.verify.transfer.$token.tsx - [`d38a12c`](https://github.com/documenso/documenso/commit/d38a12ccb4914a39fe740c554ae5c12d6eb4651b) Merge branch 'main' into main ### 📊 Changes **1 file changed** (+0 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/routes/_unauthenticated+/team.verify.transfer.$token.tsx` (+0 -0) </details> ### 📄 Description fix: dynamic route handling for /team/verify/transfer/:token --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description <!--- Describe the changes introduced by this pull request. --> Renamed team.verify.transfer.token.tsx to team.verify.transfer.$token.tsx in apps/remix/app/routes/_unauthenticated+/ <!--- Explain what problem it solves or what feature/fix it adds. --> Team transfer links sent via mail e.g.: https://server.domain/team/verify/transfer/u6t-gx4ryxDYALvFKuVdidSWXXzh9nfH Threw errors in the log: ``` Error: No route matches URL "/team/verify/transfer/u6t-gx4ryxDYALvFKuVdidSWXXzh9nfH" at getInternalRouterError (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:3776:5) at Object.query (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:2606:19) at handleDocumentRequest (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:9157:35) at requestHandler (file:///srv/documenso/node_modules/react-router/dist/development/chunk-IR6S3I6Y.mjs:9074:24) at file:///srv/documenso/node_modules/hono-react-router-adapter/dist/handlers/node/index.js:22:18 at file:///srv/documenso/node_modules/hono-react-router-adapter/dist/handlers/node/index.js:45:7 at dispatch (file:///srv/documenso/node_modules/hono/dist/compose.js:30:23) at file:///srv/documenso/node_modules/hono/dist/compose.js:31:20 at file:///srv/documenso/node_modules/@hono/node-server/dist/serve-static.mjs:76:14 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) No routes matched location "/team/verify/transfer/u6t-gx4ryxDYALvFKuVdidSWXXzh9nfH" ``` and thus the transfer could not be completed. ## Related Issue <!--- If this pull request is related to a specific issue, reference it here using #issue_number. --> <!--- For example, "Fixes #123" or "Addresses #456". --> ## Changes Made Renamed team.verify.transfer.token.tsx to team.verify.transfer.$token.tsx in apps/remix/app/routes/_unauthenticated+/ ## Testing Performed Team transfer accept links work after the fix. ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <!--- Provide any additional context or notes for the reviewers. --> <!--- This might include details about design decisions, potential concerns, or anything else relevant. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:31:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1816
No description provided.