starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1721] [MERGED] fix: duplicate webhook calls on document complete #1812

New issue

Closed

opened 2026-02-26 20:31:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1721
Author: @dguyen
Created: 3/25/2025
Status: ✅ Merged
Merged: 3/25/2025
Merged by: @Mythie

Base: main ← Head: fix/duplicate-webhooks

📝 Commits (2)

02a9b26 fix: duplicate webhook calls on document complete
8caaba1 fix: test

📊 Changes

12 files changed (+78 additions, -191 deletions)

View changed files

📝 apps/remix/app/components/dialogs/assistant-confirmation-dialog.tsx (+63 -102)
📝 apps/remix/app/components/general/document-signing/document-signing-form.tsx (+9 -50)
📝 packages/app-tests/e2e/document-auth/next-recipient-dictation.spec.ts (+0 -3)
📝 packages/app-tests/e2e/teams/team-signature-settings.spec.ts (+4 -0)
📝 packages/lib/translations/de/web.po (+0 -6)
📝 packages/lib/translations/en/web.po (+0 -6)
📝 packages/lib/translations/es/web.po (+0 -6)
📝 packages/lib/translations/fr/web.po (+0 -6)
📝 packages/lib/translations/it/web.po (+0 -6)
📝 packages/lib/translations/pl/web.po (+0 -6)
📝 packages/trpc/server/document-router/update-document.ts (+1 -0)
📝 packages/ui/primitives/toast.tsx (+1 -0)

📄 Description

Description

Fix webhooks being sent twice due to duplicate frontend calls

Updated the assistant confirmation dialog so the next signer is always visible (if dictate is enabled). Because if the form is invalid (due to no name) there is no visual queue that the form is invalid (since it's hidden)

Notes

Didn't bother to remove the weird assistants form since it currently works for now

Tests

Currently running locally
Tested webhooks via network tab and via webhook.site

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1721 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 3/25/2025 **Status:** ✅ Merged **Merged:** 3/25/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/duplicate-webhooks` --- ### 📝 Commits (2) - [`02a9b26`](https://github.com/documenso/documenso/commit/02a9b260b81c910300a3c66041b6549d7d5d5791) fix: duplicate webhook calls on document complete - [`8caaba1`](https://github.com/documenso/documenso/commit/8caaba13538cd6250c5b9a98f9410d6559b66f1e) fix: test ### 📊 Changes **12 files changed** (+78 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/assistant-confirmation-dialog.tsx` (+63 -102) 📝 `apps/remix/app/components/general/document-signing/document-signing-form.tsx` (+9 -50) 📝 `packages/app-tests/e2e/document-auth/next-recipient-dictation.spec.ts` (+0 -3) 📝 `packages/app-tests/e2e/teams/team-signature-settings.spec.ts` (+4 -0) 📝 `packages/lib/translations/de/web.po` (+0 -6) 📝 `packages/lib/translations/en/web.po` (+0 -6) 📝 `packages/lib/translations/es/web.po` (+0 -6) 📝 `packages/lib/translations/fr/web.po` (+0 -6) 📝 `packages/lib/translations/it/web.po` (+0 -6) 📝 `packages/lib/translations/pl/web.po` (+0 -6) 📝 `packages/trpc/server/document-router/update-document.ts` (+1 -0) 📝 `packages/ui/primitives/toast.tsx` (+1 -0) </details> ### 📄 Description ## Description Fix webhooks being sent twice due to duplicate frontend calls Updated the assistant confirmation dialog so the next signer is always visible (if dictate is enabled). Because if the form is invalid (due to no name) there is no visual queue that the form is invalid (since it's hidden) ## Notes Didn't bother to remove the weird assistants form since it currently works for now ![image](https://github.com/user-attachments/assets/47910fec-e05e-486a-a61d-16078d948893) ## Tests - Currently running locally - Tested webhooks via network tab and via webhook.site --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:10 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:47 +03:00

[PR #1945] [MERGED] feat: env for support email #1948

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1812

No description provided.

Rows
Columns