[PR #1719] [MERGED] feat: dictate next signer #1810

New issue

Closed

opened 2026-02-26 20:31:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1719
Author: @Mythie
Created: 3/21/2025
Status: ✅ Merged
Merged: 3/21/2025
Merged by: @Mythie

Base: main ← Head: feat/dictate-signing-order

📝 Commits (3)

8bc1805 feat: dictate next signer
56c6c3a fix: remove unused prop
02d4c9c fix: invert boolean

📊 Changes

31 files changed (+1229 additions, -217 deletions)

View changed files

📝 apps/remix/app/components/dialogs/assistant-confirmation-dialog.tsx (+180 -31)
📝 apps/remix/app/components/general/document-signing/document-signing-complete-dialog.tsx (+235 -102)
📝 apps/remix/app/components/general/document-signing/document-signing-form.tsx (+124 -42)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view.tsx (+4 -4)
📝 apps/remix/app/components/general/document/document-edit-form.tsx (+11 -3)
📝 apps/remix/app/components/general/template/template-edit-form.tsx (+2 -0)
📝 apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx (+20 -2)
📝 packages/api/v1/implementation.ts (+1 -0)
📝 packages/api/v1/schema.ts (+3 -0)
📝 packages/app-tests/e2e/document-auth/action-auth.spec.ts (+2 -2)
➕ packages/app-tests/e2e/document-auth/next-recipient-dictation.spec.ts (+390 -0)
📝 packages/app-tests/e2e/public-profiles/public-profiles.spec.ts (+2 -0)
📝 packages/lib/server-only/document-meta/upsert-document-meta.ts (+4 -0)
📝 packages/lib/server-only/document/complete-document-with-token.ts (+53 -3)
➕ packages/lib/server-only/recipient/get-next-pending-recipient.ts (+37 -0)
📝 packages/lib/server-only/template/create-document-from-template.ts (+5 -0)
📝 packages/lib/types/document.ts (+1 -0)
📝 packages/lib/types/template.ts (+1 -0)
📝 packages/lib/types/webhook-payload.ts (+1 -0)
➕ packages/prisma/migrations/20250320113205_add_dictate_signing_order_meta_field/migration.sql (+2 -0)

...and 11 more files

📄 Description

Description

Adds next recipient dictation functionality to document signing flow, allowing assistants and signers to update the next recipient's information during the signing process.

N/A

Changes Made

Added form handling for next recipient dictation in signing dialogs
Implemented UI for updating next recipient information
Added e2e tests covering dictation scenarios:
- Regular signing with dictation enabled
- Assistant role with dictation
- Parallel signing flow
- Disabled dictation state

Testing Performed

Added comprehensive e2e tests covering:
- Sequential signing with dictation
- Assistant role dictation
- Parallel signing without dictation
- Form validation and state management
Tested on Chrome and Firefox
Verified recipient state updates in database

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1719 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 3/21/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/dictate-signing-order` --- ### 📝 Commits (3) - [`8bc1805`](https://github.com/documenso/documenso/commit/8bc1805a41cf61f3cd7e00347da1b7e7ebdbb2fa) feat: dictate next signer - [`56c6c3a`](https://github.com/documenso/documenso/commit/56c6c3a477d876614123221ab4817556f5fd06ab) fix: remove unused prop - [`02d4c9c`](https://github.com/documenso/documenso/commit/02d4c9c318cffba958129a8c7016c1eb48a6b9d9) fix: invert boolean ### 📊 Changes **31 files changed** (+1229 additions, -217 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/assistant-confirmation-dialog.tsx` (+180 -31) 📝 `apps/remix/app/components/general/document-signing/document-signing-complete-dialog.tsx` (+235 -102) 📝 `apps/remix/app/components/general/document-signing/document-signing-form.tsx` (+124 -42) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view.tsx` (+4 -4) 📝 `apps/remix/app/components/general/document/document-edit-form.tsx` (+11 -3) 📝 `apps/remix/app/components/general/template/template-edit-form.tsx` (+2 -0) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx` (+20 -2) 📝 `packages/api/v1/implementation.ts` (+1 -0) 📝 `packages/api/v1/schema.ts` (+3 -0) 📝 `packages/app-tests/e2e/document-auth/action-auth.spec.ts` (+2 -2) ➕ `packages/app-tests/e2e/document-auth/next-recipient-dictation.spec.ts` (+390 -0) 📝 `packages/app-tests/e2e/public-profiles/public-profiles.spec.ts` (+2 -0) 📝 `packages/lib/server-only/document-meta/upsert-document-meta.ts` (+4 -0) 📝 `packages/lib/server-only/document/complete-document-with-token.ts` (+53 -3) ➕ `packages/lib/server-only/recipient/get-next-pending-recipient.ts` (+37 -0) 📝 `packages/lib/server-only/template/create-document-from-template.ts` (+5 -0) 📝 `packages/lib/types/document.ts` (+1 -0) 📝 `packages/lib/types/template.ts` (+1 -0) 📝 `packages/lib/types/webhook-payload.ts` (+1 -0) ➕ `packages/prisma/migrations/20250320113205_add_dictate_signing_order_meta_field/migration.sql` (+2 -0) _...and 11 more files_ </details> ### 📄 Description ## Description Adds next recipient dictation functionality to document signing flow, allowing assistants and signers to update the next recipient's information during the signing process. ## Related Issue N/A ## Changes Made - Added form handling for next recipient dictation in signing dialogs - Implemented UI for updating next recipient information - Added e2e tests covering dictation scenarios: - Regular signing with dictation enabled - Assistant role with dictation - Parallel signing flow - Disabled dictation state ## Testing Performed - Added comprehensive e2e tests covering: - Sequential signing with dictation - Assistant role dictation - Parallel signing without dictation - Form validation and state management - Tested on Chrome and Firefox - Verified recipient state updates in database --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:10 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1810

No description provided.

Rows
Columns