starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1710] [MERGED] feat: add signature configurations #1807

New issue

Closed

opened 2026-02-26 20:31:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1710
Author: @dguyen
Created: 3/17/2025
Status: ✅ Merged
Merged: 3/24/2025
Merged by: @Mythie

Base: feat/rr7 ← Head: feat/signature-configs

📝 Commits (4)

9560f85 feat: add signature configs
ccc9fce fix: redundant signature checks
4e7348a fix: tests
36cc94a Merge branch 'feat/rr7' into feat/signature-configs

📊 Changes

78 files changed (+2383 additions, -1105 deletions)

View changed files

📝 apps/remix/app/components/embed/embed-direct-template-client-page.tsx (+14 -45)
📝 apps/remix/app/components/embed/embed-document-fields.tsx (+2 -0)
📝 apps/remix/app/components/embed/embed-document-signing-page.tsx (+14 -46)
📝 apps/remix/app/components/forms/profile.tsx (+11 -10)
📝 apps/remix/app/components/forms/signup.tsx (+4 -5)
📝 apps/remix/app/components/forms/team-branding-preferences-form.tsx (+1 -1)
📝 apps/remix/app/components/forms/team-document-preferences-form.tsx (+52 -35)
📝 apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx (+13 -23)
📝 apps/remix/app/components/general/document-signing/document-signing-form.tsx (+11 -34)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view.tsx (+2 -0)
📝 apps/remix/app/components/general/document-signing/document-signing-provider.tsx (+26 -12)
📝 apps/remix/app/components/general/document-signing/document-signing-signature-field.tsx (+20 -34)
📝 apps/remix/app/components/general/document/document-edit-form.tsx (+6 -11)
📝 apps/remix/app/components/general/template/template-edit-form.tsx (+6 -8)
📝 apps/remix/app/routes/_recipient+/d.$token+/_index.tsx (+8 -1)
📝 apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx (+3 -0)
📝 apps/remix/app/routes/embed+/direct.$url.tsx (+8 -1)
📝 apps/remix/app/routes/embed+/sign.$url.tsx (+3 -0)
📝 packages/api/v1/implementation.ts (+2 -0)
📝 packages/api/v1/schema.ts (+4 -0)

...and 58 more files

📄 Description

Description

Add ability to enable or disable allowed signature types:

Drawn
Typed
Uploaded

Tabbed style signature dialog

Document settings

Team preferences

Changes Made

Add multiselect to select allowed signatures in document and templates settings tab
Add multiselect to select allowed signatures in teams preferences
Removed "Enable typed signatures" from document/template edit page
Refactored signature pad to use tabs instead of an all in one signature pad

Testing Performed

Added E2E tests to check settings are applied correctly for documents and templates

Todo: Test embed styling

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1710 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 3/24/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/rr7` ← **Head:** `feat/signature-configs` --- ### 📝 Commits (4) - [`9560f85`](https://github.com/documenso/documenso/commit/9560f85d8d27f185b582b4ae08e54cbc8de45a35) feat: add signature configs - [`ccc9fce`](https://github.com/documenso/documenso/commit/ccc9fceac381acd7d4938d503851588095a38f06) fix: redundant signature checks - [`4e7348a`](https://github.com/documenso/documenso/commit/4e7348a6e26c8e9140c1f8b1077db4d3eb20d400) fix: tests - [`36cc94a`](https://github.com/documenso/documenso/commit/36cc94a9dcb972b6c65e216824f1c007297cbe0a) Merge branch 'feat/rr7' into feat/signature-configs ### 📊 Changes **78 files changed** (+2383 additions, -1105 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/embed/embed-direct-template-client-page.tsx` (+14 -45) 📝 `apps/remix/app/components/embed/embed-document-fields.tsx` (+2 -0) 📝 `apps/remix/app/components/embed/embed-document-signing-page.tsx` (+14 -46) 📝 `apps/remix/app/components/forms/profile.tsx` (+11 -10) 📝 `apps/remix/app/components/forms/signup.tsx` (+4 -5) 📝 `apps/remix/app/components/forms/team-branding-preferences-form.tsx` (+1 -1) 📝 `apps/remix/app/components/forms/team-document-preferences-form.tsx` (+52 -35) 📝 `apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx` (+13 -23) 📝 `apps/remix/app/components/general/document-signing/document-signing-form.tsx` (+11 -34) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view.tsx` (+2 -0) 📝 `apps/remix/app/components/general/document-signing/document-signing-provider.tsx` (+26 -12) 📝 `apps/remix/app/components/general/document-signing/document-signing-signature-field.tsx` (+20 -34) 📝 `apps/remix/app/components/general/document/document-edit-form.tsx` (+6 -11) 📝 `apps/remix/app/components/general/template/template-edit-form.tsx` (+6 -8) 📝 `apps/remix/app/routes/_recipient+/d.$token+/_index.tsx` (+8 -1) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx` (+3 -0) 📝 `apps/remix/app/routes/embed+/direct.$url.tsx` (+8 -1) 📝 `apps/remix/app/routes/embed+/sign.$url.tsx` (+3 -0) 📝 `packages/api/v1/implementation.ts` (+2 -0) 📝 `packages/api/v1/schema.ts` (+4 -0) _...and 58 more files_ </details> ### 📄 Description ## Description Add ability to enable or disable allowed signature types: - Drawn - Typed - Uploaded **Tabbed style signature dialog** ![image](https://github.com/user-attachments/assets/a816fab6-b071-42a5-bb5c-6d4a2572431e) **Document settings** ![image](https://github.com/user-attachments/assets/f0c1bff1-6be1-4c87-b384-1666fa25d7a6) **Team preferences** ![image](https://github.com/user-attachments/assets/8767b05e-1463-4087-8672-f3f43d8b0f2c) ## Changes Made - Add multiselect to select allowed signatures in document and templates settings tab - Add multiselect to select allowed signatures in teams preferences - Removed "Enable typed signatures" from document/template edit page - Refactored signature pad to use tabs instead of an all in one signature pad ## Testing Performed Added E2E tests to check settings are applied correctly for documents and templates Todo: Test embed styling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:09 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1807

No description provided.

Rows
Columns