starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 14:25:59 +03:00

[PR #1702] [MERGED] feat: better document rejection #1802

New issue

Closed

opened 2026-02-26 20:31:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1702
Author: @Mythie
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/13/2025
Merged by: @Mythie

Base: feat/rr7 ← Head: feat/better-document-rejection

📝 Commits (2)

810a4ee feat: better document rejection
7c659af chore: remove console.log

📊 Changes

46 files changed (+520 additions, -110 deletions)

View changed files

📝 apps/remix/app/components/dialogs/document-delete-dialog.tsx (+2 -2)
📝 apps/remix/app/components/general/document/document-certificate-download-button.tsx (+3 -2)
📝 apps/remix/app/components/general/document/document-page-view-button.tsx (+2 -1)
📝 apps/remix/app/components/general/document/document-page-view-dropdown.tsx (+2 -1)
📝 apps/remix/app/components/general/document/document-page-view-recipients.tsx (+2 -1)
📝 apps/remix/app/components/general/document/document-status.tsx (+7 -1)
📝 apps/remix/app/components/tables/documents-table-action-button.tsx (+2 -1)
📝 apps/remix/app/components/tables/documents-table-action-dropdown.tsx (+2 -1)
📝 apps/remix/app/components/tables/documents-table.tsx (+2 -2)
📝 apps/remix/app/routes/_authenticated+/admin+/documents.$id.tsx (+3 -1)
📝 apps/remix/app/routes/_authenticated+/documents.$id._index.tsx (+3 -0)
📝 apps/remix/app/routes/_authenticated+/documents.$id.edit.tsx (+3 -2)
📝 apps/remix/app/routes/_authenticated+/documents._index.tsx (+1 -0)
📝 apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx (+40 -16)
📝 apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx (+1 -1)
📝 apps/remix/app/routes/_recipient+/sign.$token+/complete.tsx (+4 -3)
📝 apps/remix/app/routes/embed+/sign.$url.tsx (+3 -2)
📝 packages/api/v1/implementation.ts (+10 -9)
📝 packages/api/v1/schema.ts (+1 -1)
📝 packages/email/template-components/template-document-cancel.tsx (+8 -0)

...and 26 more files

📄 Description

Description

Improves the existing document rejection process by actually marking a document as completed cancelling further actions.

N/A

Changes Made

Added a new rejection status for documents
Updated a million areas that check for document completion
Updated email sending, so rejection is confirmed for the rejecting recipient while other recipients are notified that the document is now cancelled.

Testing Performed

Ran the testing suite to ensure there are no regressions.
Performed manual testing of current core flows.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1702 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/13/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/rr7` ← **Head:** `feat/better-document-rejection` --- ### 📝 Commits (2) - [`810a4ee`](https://github.com/documenso/documenso/commit/810a4eea3aa6385af5d8c5d409ed502885cb0268) feat: better document rejection - [`7c659af`](https://github.com/documenso/documenso/commit/7c659af12d1772009897d99b3206b6e2e09be881) chore: remove console.log ### 📊 Changes **46 files changed** (+520 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/document-delete-dialog.tsx` (+2 -2) 📝 `apps/remix/app/components/general/document/document-certificate-download-button.tsx` (+3 -2) 📝 `apps/remix/app/components/general/document/document-page-view-button.tsx` (+2 -1) 📝 `apps/remix/app/components/general/document/document-page-view-dropdown.tsx` (+2 -1) 📝 `apps/remix/app/components/general/document/document-page-view-recipients.tsx` (+2 -1) 📝 `apps/remix/app/components/general/document/document-status.tsx` (+7 -1) 📝 `apps/remix/app/components/tables/documents-table-action-button.tsx` (+2 -1) 📝 `apps/remix/app/components/tables/documents-table-action-dropdown.tsx` (+2 -1) 📝 `apps/remix/app/components/tables/documents-table.tsx` (+2 -2) 📝 `apps/remix/app/routes/_authenticated+/admin+/documents.$id.tsx` (+3 -1) 📝 `apps/remix/app/routes/_authenticated+/documents.$id._index.tsx` (+3 -0) 📝 `apps/remix/app/routes/_authenticated+/documents.$id.edit.tsx` (+3 -2) 📝 `apps/remix/app/routes/_authenticated+/documents._index.tsx` (+1 -0) 📝 `apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx` (+40 -16) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx` (+1 -1) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/complete.tsx` (+4 -3) 📝 `apps/remix/app/routes/embed+/sign.$url.tsx` (+3 -2) 📝 `packages/api/v1/implementation.ts` (+10 -9) 📝 `packages/api/v1/schema.ts` (+1 -1) 📝 `packages/email/template-components/template-document-cancel.tsx` (+8 -0) _...and 26 more files_ </details> ### 📄 Description ## Description Improves the existing document rejection process by actually marking a document as completed cancelling further actions. ## Related Issue N/A ## Changes Made - Added a new rejection status for documents - Updated a million areas that check for document completion - Updated email sending, so rejection is confirmed for the rejecting recipient while other recipients are notified that the document is now cancelled. ## Testing Performed - Ran the testing suite to ensure there are no regressions. - Performed manual testing of current core flows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:08 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:23 +03:00

[PR #1802] [MERGED] feat: show field coordinates in devmode #1857

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1802

No description provided.

Rows
Columns