[PR #1691] [MERGED] fix: optional fields in embeds #1794

New issue

Closed

opened 2026-02-26 20:31:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1691
Author: @catalinpit
Created: 3/7/2025
Status: ✅ Merged
Merged: 3/7/2025
Merged by: @Mythie

Base: main ← Head: fix/optional-fields-embeds

📝 Commits (3)

daf0774 fix: optional fields in embeds
caad5c8 chore: allow empty fields template embedding
a880210 chore: fix ts errors

📊 Changes

6 files changed (+57 additions, -33 deletions)

View changed files

📝 apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx (+3 -3)
📝 apps/web/src/app/embed/direct/[[...url]]/client.tsx (+17 -19)
📝 apps/web/src/app/embed/sign/[[...url]]/client.tsx (+12 -4)
📝 packages/lib/server-only/template/create-document-from-direct-template.ts (+23 -5)
📝 packages/trpc/server/field-router/router.ts (+1 -1)
📝 packages/trpc/server/field-router/schema.ts (+1 -1)

📄 Description

Fix optional fields blocking the signature process in embeds

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1691 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/optional-fields-embeds` --- ### 📝 Commits (3) - [`daf0774`](https://github.com/documenso/documenso/commit/daf0774fd5f620242dbfd5b58377faf8fd7d1f90) fix: optional fields in embeds - [`caad5c8`](https://github.com/documenso/documenso/commit/caad5c8a2389c29a7440216329f7bb6c3817d178) chore: allow empty fields template embedding - [`a880210`](https://github.com/documenso/documenso/commit/a880210e96e9f3e1a2356c682fe8aef3242995e9) chore: fix ts errors ### 📊 Changes **6 files changed** (+57 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx` (+3 -3) 📝 `apps/web/src/app/embed/direct/[[...url]]/client.tsx` (+17 -19) 📝 `apps/web/src/app/embed/sign/[[...url]]/client.tsx` (+12 -4) 📝 `packages/lib/server-only/template/create-document-from-direct-template.ts` (+23 -5) 📝 `packages/trpc/server/field-router/router.ts` (+1 -1) 📝 `packages/trpc/server/field-router/schema.ts` (+1 -1) </details> ### 📄 Description Fix optional fields blocking the signature process in embeds --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:06 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:21 +03:00

[PR #1794] [MERGED] fix: allow prefilling date field #1852

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1794

No description provided.

Rows
Columns