[PR #1676] [MERGED] feat: hide signature ui when theres no signature field #1785

New issue

Closed

opened 2026-02-26 20:31:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1676
Author: @ephraimduncan
Created: 2/26/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @Mythie

Base: main ← Head: feat/hide-signature-ui

📝 Commits (5)

92ecb60 feat: hide signature ui when theres no signature field
d434402 feat: change wording
4b9e481 Merge branch 'main' into feat/hide-signature-ui
6a1d988 fix: make signature hiding consistent across embeds
3fc7103 chore: update tests

📊 Changes

6 files changed (+207 additions, -149 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+39 -33)
📝 apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx (+77 -46)
📝 apps/web/src/app/embed/direct/[[...url]]/client.tsx (+36 -34)
📝 apps/web/src/app/embed/sign/[[...url]]/client.tsx (+36 -34)
📝 package-lock.json (+15 -0)
📝 packages/app-tests/e2e/document-flow/stepper-component.spec.ts (+4 -2)

📄 Description

demo

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1676 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/hide-signature-ui` --- ### 📝 Commits (5) - [`92ecb60`](https://github.com/documenso/documenso/commit/92ecb6093f56cfb2936f40ce2385cc36ea28d885) feat: hide signature ui when theres no signature field - [`d434402`](https://github.com/documenso/documenso/commit/d43440274dd53e131b6cd705c4c96bc4ccd8bfe0) feat: change wording - [`4b9e481`](https://github.com/documenso/documenso/commit/4b9e48136b72dc26dcf074e46e8163aa5fa4ff89) Merge branch 'main' into feat/hide-signature-ui - [`6a1d988`](https://github.com/documenso/documenso/commit/6a1d98845709db663e227ca98433b8c9079c73fe) fix: make signature hiding consistent across embeds - [`3fc7103`](https://github.com/documenso/documenso/commit/3fc71039ed517fd819e2f9823ada5c7fe9a69cf8) chore: update tests ### 📊 Changes **6 files changed** (+207 additions, -149 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+39 -33) 📝 `apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx` (+77 -46) 📝 `apps/web/src/app/embed/direct/[[...url]]/client.tsx` (+36 -34) 📝 `apps/web/src/app/embed/sign/[[...url]]/client.tsx` (+36 -34) 📝 `package-lock.json` (+15 -0) 📝 `packages/app-tests/e2e/document-flow/stepper-component.spec.ts` (+4 -2) </details> ### 📄 Description ## demo ![CleanShot 2025-02-26 at 23 25 52@2x](https://github.com/user-attachments/assets/cb4be487-ebb1-4fdc-aa7e-c1d11e2f6f4f) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:03 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1785

No description provided.

Rows
Columns