[GH-ISSUE #635] improvement: fix the validation message for documenso app #176

Closed
opened 2026-02-26 18:45:43 +03:00 by kerem · 4 comments
Owner

Originally created by @anikdhabal on GitHub (Nov 8, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/635

Originally assigned to: @anikdhabal on GitHub.

Issue Description

There are some input fields where I believe improvements are needed for the error messages displayed when an input field is empty, and someone attempts to proceed to the next step.

1.) In the Sign-In form and the reset password form, when the password field is empty, it shows the message "String must contain at least 6 character(s)."

2.) The email field in the "Add Signer" form displays "String must contain at least 1 character(s)."

Steps to Reproduce

No response

Expected Behavior

1.) When the password field is empty, the error message should be "Invalid Password," similar to the email field.

2.) Instead of "String must contain at least 1 character(s)," the email field should display "Email is required," similar to how the name field behaves.

Current Behavior

No response

Screenshots (optional)

Current behavior:-

Screenshot 2023-11-08 131922

Screenshot 2023-11-08 132454

Screenshot 2023-11-08 145659

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

No response

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
Originally created by @anikdhabal on GitHub (Nov 8, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/635 Originally assigned to: @anikdhabal on GitHub. ### Issue Description There are some input fields where I believe improvements are needed for the error messages displayed when an input field is empty, and someone attempts to proceed to the next step. 1.) In the Sign-In form and the reset password form, when the password field is empty, it shows the message "String must contain at least 6 character(s)." 2.) The email field in the "Add Signer" form displays "String must contain at least 1 character(s)." ### Steps to Reproduce _No response_ ### Expected Behavior 1.) When the password field is empty, the error message should be "Invalid Password," similar to the email field. 2.) Instead of "String must contain at least 1 character(s)," the email field should display "Email is required," similar to how the name field behaves. ### Current Behavior _No response_ ### Screenshots (optional) Current behavior:- ![Screenshot 2023-11-08 131922](https://github.com/documenso/documenso/assets/81948346/6813c47c-de03-4956-a66f-fee9e37ccfad) ![Screenshot 2023-11-08 132454](https://github.com/documenso/documenso/assets/81948346/c18c9271-f4bf-4256-8dfb-c5ce900d98b1) ![Screenshot 2023-11-08 145659](https://github.com/documenso/documenso/assets/81948346/56df6a86-6475-4d3f-aa2a-0737c7dfca65) ### Operating System [e.g., Windows 10] _No response_ ### Browser [e.g., Chrome, Firefox] _No response_ ### Version [e.g., 2.0.1] _No response_ ### Please check the boxes that apply to this issue report. - [X] I have searched the existing issues to make sure this is not a duplicate. - [ ] I have provided steps to reproduce the issue. - [ ] I have included relevant environment information. - [X] I have included any relevant screenshots. - [ ] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [X] I want to work on creating a PR for this issue if approved
kerem 2026-02-26 18:45:43 +03:00
  • closed this issue
  • added the
    community
    label
Author
Owner

@anikdhabal commented on GitHub (Nov 8, 2023):

cc @Mythie @catalinpit

<!-- gh-comment-id:1801301975 --> @anikdhabal commented on GitHub (Nov 8, 2023): cc @Mythie @catalinpit
Author
Owner

@catalinpit commented on GitHub (Nov 8, 2023):

Hey @anikdhabal, thanks for the suggestions! Yes, I agree that the messages could be improved.

Just to make sure, this is for the Documenso app, right? Cause already have an open issue for the Singleplayer Mode https://github.com/documenso/documenso/issues/593

<!-- gh-comment-id:1801358257 --> @catalinpit commented on GitHub (Nov 8, 2023): Hey @anikdhabal, thanks for the suggestions! Yes, I agree that the messages could be improved. Just to make sure, this is for the Documenso app, right? Cause already have an open issue for the Singleplayer Mode https://github.com/documenso/documenso/issues/593
Author
Owner

@anikdhabal commented on GitHub (Nov 8, 2023):

Hey @anikdhabal, thanks for the suggestions! Yes, I agree that the messages could be improved.

Just to make sure, this is for the Documenso app, right? Cause already have an open issue for the Singleplayer Mode #593

Thank you for your review. Since there was a similar issue for the single-player mode, I will now work on the issue specific to the Documenso app. Along with this issue #632

<!-- gh-comment-id:1801377151 --> @anikdhabal commented on GitHub (Nov 8, 2023): > Hey @anikdhabal, thanks for the suggestions! Yes, I agree that the messages could be improved. > > Just to make sure, this is for the Documenso app, right? Cause already have an open issue for the Singleplayer Mode #593 Thank you for your review. Since there was a similar issue for the single-player mode, I will now work on the issue specific to the Documenso app. Along with this issue #632
Author
Owner

@anikdhabal commented on GitHub (Nov 8, 2023):

Pls assign me this issue.

<!-- gh-comment-id:1801761658 --> @anikdhabal commented on GitHub (Nov 8, 2023): Pls assign me this issue.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#176
No description provided.