[PR #1609] [CLOSED] feat: allow same signer email multiple times #1751

New issue

Closed

opened 2026-02-26 20:30:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:30:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1609
Author: @catalinpit
Created: 1/27/2025
Status: ❌ Closed

Base: archive/nextjs ← Head: feat/allow-same-signer-email-multiple-times

📝 Commits (10+)

b01eace feat: allow same signer email multiple times
9f9f670 chore: remove same email check from backend
071f5c5 chore: remove same email check from backend
3cde3cb Merge branch 'main' into feat/allow-same-signer-email-multiple-times
0216af4 Merge branch 'main' into feat/allow-same-signer-email-multiple-times
516435f Merge branch 'main' into feat/allow-same-signer-email-multiple-times
c410023 chore: allow same signer docs
12803d1 chore: undo code
b684b95 chore: reverse some code changes
2896673 chore: allow duplicate recipient in templates

📊 Changes

29 files changed (+1545 additions, -293 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/templates/use-template-dialog.tsx (+16 -44)
📝 packages/api/v1/schema.ts (+2 -3)
➕ packages/app-tests/e2e/document-flow/fields-step.spec.ts (+304 -0)
📝 packages/app-tests/e2e/document-flow/signers-step.spec.ts (+188 -0)
➕ packages/app-tests/e2e/templates-flow/template-fields-step.spec.ts (+292 -0)
📝 packages/app-tests/e2e/templates-flow/template-signers-step.spec.ts (+132 -0)
📝 packages/app-tests/e2e/templates/create-document-from-template.spec.ts (+378 -19)
📝 packages/lib/server-only/field/set-fields-for-document.ts (+20 -7)
📝 packages/lib/server-only/field/set-fields-for-template.ts (+20 -4)
📝 packages/lib/server-only/recipient/set-document-recipients.ts (+2 -6)
📝 packages/lib/server-only/recipient/set-template-recipients.ts (+3 -10)
📝 packages/lib/server-only/template/create-document-from-template-legacy.ts (+2 -4)
📝 packages/lib/server-only/template/create-document-from-template.ts (+13 -2)
➕ packages/prisma/migrations/20250205122523_remove_unique_email_recipient/migration.sql (+2 -0)
➕ packages/prisma/migrations/20250206120241_add_email_index_recipient_model/migration.sql (+5 -0)
📝 packages/prisma/schema.prisma (+1 -2)
📝 packages/trpc/server/document-router/schema.ts (+0 -8)
📝 packages/trpc/server/field-router/router.ts (+3 -1)
📝 packages/trpc/server/field-router/schema.ts (+9 -5)
📝 packages/trpc/server/recipient-router/schema.ts (+30 -90)

...and 9 more files

📄 Description

Only duplicate recipients in a document

https://github.com/user-attachments/assets/5aa6e701-50e3-4dbd-b879-fb46b0bd161e

Create a document from template with only duplicate signers

VIdeo link (too big too upload here and can't find the raw file to export it again)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1609 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 1/27/2025 **Status:** ❌ Closed **Base:** `archive/nextjs` ← **Head:** `feat/allow-same-signer-email-multiple-times` --- ### 📝 Commits (10+) - [`b01eace`](https://github.com/documenso/documenso/commit/b01eaceeb8ce57a1d662fe81890b2b9d448c389d) feat: allow same signer email multiple times - [`9f9f670`](https://github.com/documenso/documenso/commit/9f9f6701c86143c3bdcd653dec8c2f0629145146) chore: remove same email check from backend - [`071f5c5`](https://github.com/documenso/documenso/commit/071f5c546d56fb0781c9f775cb386eadec4d6286) chore: remove same email check from backend - [`3cde3cb`](https://github.com/documenso/documenso/commit/3cde3cb7b25806e89168438861787698bed71cfd) Merge branch 'main' into feat/allow-same-signer-email-multiple-times - [`0216af4`](https://github.com/documenso/documenso/commit/0216af4ae8c605e95eeaea9a5fccf854ba8cc502) Merge branch 'main' into feat/allow-same-signer-email-multiple-times - [`516435f`](https://github.com/documenso/documenso/commit/516435fa2a3567152c9c8ae8550e89970935d563) Merge branch 'main' into feat/allow-same-signer-email-multiple-times - [`c410023`](https://github.com/documenso/documenso/commit/c41002313afeff13a0cef32b77590742d481ca27) chore: allow same signer docs - [`12803d1`](https://github.com/documenso/documenso/commit/12803d1a5e1ca57b611495b9e3652d9fba8123a4) chore: undo code - [`b684b95`](https://github.com/documenso/documenso/commit/b684b9574dbb335e02e5e254ea56a87e5f50d446) chore: reverse some code changes - [`2896673`](https://github.com/documenso/documenso/commit/2896673a2396725368afac57e3f90498f0030baa) chore: allow duplicate recipient in templates ### 📊 Changes **29 files changed** (+1545 additions, -293 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/templates/use-template-dialog.tsx` (+16 -44) 📝 `packages/api/v1/schema.ts` (+2 -3) ➕ `packages/app-tests/e2e/document-flow/fields-step.spec.ts` (+304 -0) 📝 `packages/app-tests/e2e/document-flow/signers-step.spec.ts` (+188 -0) ➕ `packages/app-tests/e2e/templates-flow/template-fields-step.spec.ts` (+292 -0) 📝 `packages/app-tests/e2e/templates-flow/template-signers-step.spec.ts` (+132 -0) 📝 `packages/app-tests/e2e/templates/create-document-from-template.spec.ts` (+378 -19) 📝 `packages/lib/server-only/field/set-fields-for-document.ts` (+20 -7) 📝 `packages/lib/server-only/field/set-fields-for-template.ts` (+20 -4) 📝 `packages/lib/server-only/recipient/set-document-recipients.ts` (+2 -6) 📝 `packages/lib/server-only/recipient/set-template-recipients.ts` (+3 -10) 📝 `packages/lib/server-only/template/create-document-from-template-legacy.ts` (+2 -4) 📝 `packages/lib/server-only/template/create-document-from-template.ts` (+13 -2) ➕ `packages/prisma/migrations/20250205122523_remove_unique_email_recipient/migration.sql` (+2 -0) ➕ `packages/prisma/migrations/20250206120241_add_email_index_recipient_model/migration.sql` (+5 -0) 📝 `packages/prisma/schema.prisma` (+1 -2) 📝 `packages/trpc/server/document-router/schema.ts` (+0 -8) 📝 `packages/trpc/server/field-router/router.ts` (+3 -1) 📝 `packages/trpc/server/field-router/schema.ts` (+9 -5) 📝 `packages/trpc/server/recipient-router/schema.ts` (+30 -90) _...and 9 more files_ </details> ### 📄 Description ## Only duplicate recipients in a document https://github.com/user-attachments/assets/5aa6e701-50e3-4dbd-b879-fb46b0bd161e ## Create a document from template with only duplicate signers [VIdeo link](https://vimeo.com/1055946754/01a223bd2c?share=copy) (too big too upload here and can't find the raw file to export it again) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:30:55 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:14 +03:00

[PR #1751] [MERGED] chore: remove legacy document update route #1826

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1751

No description provided.

Rows
Columns