[PR #1597] [MERGED] fix: tidy document invite email render logic #1744

New issue

Closed

opened 2026-02-26 20:30:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:30:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1597
Author: @Mythie
Created: 1/19/2025
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @Mythie

Base: main ← Head: fix/tidy-document-invite-email-render-logic

📝 Commits (2)

51d9aab fix: tidy document invite email render logic
b48fe96 chore: remove template string

📊 Changes

1 file changed (+28 additions, -29 deletions)

View changed files

📝 packages/email/template-components/template-document-invite.tsx (+28 -29)

📄 Description

Description

Updates one of our confusing ternaries to use ts-pattern for rendering the conditional blocks making it easy to follow the logic occurring.

N/A

Changes Made

Swapped ternary for ts-pattern

Testing Performed

Manually created a bunch of documents in configurations matching those required to exhaust the match conditions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1597 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 1/19/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/tidy-document-invite-email-render-logic` --- ### 📝 Commits (2) - [`51d9aab`](https://github.com/documenso/documenso/commit/51d9aabdc4afab46aae14e10fa43a8e5f2de9f66) fix: tidy document invite email render logic - [`b48fe96`](https://github.com/documenso/documenso/commit/b48fe9634b9e7fe2fdd6a454739ae9e1aafaa872) chore: remove template string ### 📊 Changes **1 file changed** (+28 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/email/template-components/template-document-invite.tsx` (+28 -29) </details> ### 📄 Description ## Description Updates one of our confusing ternaries to use `ts-pattern` for rendering the conditional blocks making it easy to follow the logic occurring. ## Related Issue N/A ## Changes Made - Swapped ternary for `ts-pattern` ## Testing Performed - Manually created a bunch of documents in configurations matching those required to exhaust the `match` conditions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:30:52 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1744

No description provided.

Rows
Columns