[PR #1596] [MERGED] fix: correct signer deletion #1743

New issue

Closed

opened 2026-02-26 20:30:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:30:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1596
Author: @ephraimduncan
Created: 1/19/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @dguyen

Base: feat/rr7 ← Head: fix/add-signers-deletion-bug

📝 Commits (1)

6725b71 fix: correct signer deletion

📊 Changes

1 file changed (+6 additions, -4 deletions)

View changed files

📝 packages/ui/primitives/document-flow/add-signers.tsx (+6 -4)

📄 Description

Before

https://github.com/user-attachments/assets/25e20a7f-d00a-48af-9e7c-392700bba9b1

After

https://github.com/user-attachments/assets/37b8e866-344b-455a-b919-58f44f93b3d9

Description

This PR fixes a bug in the signer removal functionality in the document flow. Previously, signers were being removed based on array index which could lead to incorrect removals if the form state and visual state were out of sync. The fix ensures signers are removed based on their unique formId instead.

Changes Made

Modified signer removal logic in AddSignersFormPartial component to use formId for identifying signers
Updated form state management to properly filter signers based on formId instead of array index
Ensured signing order normalization is maintained after signer removal

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1596 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 1/19/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `feat/rr7` ← **Head:** `fix/add-signers-deletion-bug` --- ### 📝 Commits (1) - [`6725b71`](https://github.com/documenso/documenso/commit/6725b717ae66369ff9d990856d9bb73a7ba24f6f) fix: correct signer deletion ### 📊 Changes **1 file changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+6 -4) </details> ### 📄 Description ## Before https://github.com/user-attachments/assets/25e20a7f-d00a-48af-9e7c-392700bba9b1 ## After https://github.com/user-attachments/assets/37b8e866-344b-455a-b919-58f44f93b3d9 ## Description This PR fixes a bug in the signer removal functionality in the document flow. Previously, signers were being removed based on array index which could lead to incorrect removals if the form state and visual state were out of sync. The fix ensures signers are removed based on their unique `formId` instead. ## Changes Made - Modified signer removal logic in `AddSignersFormPartial` component to use `formId` for identifying signers - Updated form state management to properly filter signers based on `formId` instead of array index - Ensured signing order normalization is maintained after signer removal ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:30:52 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1743

No description provided.

Rows
Columns