[PR #1588] [MERGED] feat: assistant role #1736

Closed
opened 2026-02-26 20:30:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1588
Author: @ephraimduncan
Created: 1/17/2025
Status: Merged
Merged: 2/1/2025
Merged by: @Mythie

Base: mainHead: feat/assistant-role


📝 Commits (10+)

  • 0bb0840 chore: add assistant role
  • 923e1fe feat: add role
  • 53216e6 chore: enable signing order on assitant role
  • d8b1f3c fix: correct signing order when assistant is sued
  • 8e399d9 chore: enforce signing order
  • 809d1c5 fix: signers sorting in assistant role
  • c8cab53 feat: show confirmation when disabling signing order with assistants
  • 3160fbe feat: filter assistant from adding fields
  • 1c42507 feat: add signer radio on assistant form
  • a2b46a4 feat: filter fields based on selected signer

📊 Changes

53 files changed (+1633 additions, -695 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recipients.tsx (+8 -1)
📝 apps/web/src/app/(dashboard)/documents/move-document-dialog.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/templates/move-template-dialog.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx (+5 -1)
📝 apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx (+3 -12)
apps/web/src/app/(signing)/sign/[token]/assistant/assistant-confirmation-dialog.tsx (+73 -0)
📝 apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx (+7 -10)
📝 apps/web/src/app/(signing)/sign/[token]/date-field.tsx (+7 -8)
📝 apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx (+7 -10)
📝 apps/web/src/app/(signing)/sign/[token]/email-field.tsx (+7 -5)
📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+230 -94)
📝 apps/web/src/app/(signing)/sign/[token]/initials-field.tsx (+6 -9)
📝 apps/web/src/app/(signing)/sign/[token]/name-field.tsx (+10 -8)
📝 apps/web/src/app/(signing)/sign/[token]/number-field.tsx (+26 -14)
📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+15 -4)
📝 apps/web/src/app/(signing)/sign/[token]/radio-field.tsx (+18 -6)
apps/web/src/app/(signing)/sign/[token]/recipient-context.tsx (+66 -0)
📝 apps/web/src/app/(signing)/sign/[token]/signature-field.tsx (+2 -4)
📝 apps/web/src/app/(signing)/sign/[token]/signing-field-container.tsx (+1 -0)
📝 apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx (+159 -140)

...and 33 more files

📄 Description

Demo

https://github.com/user-attachments/assets/c1321578-47ec-405b-a70a-7d9578385895

Description

Introduces the ability for users with the Assistant role to prefill fields on behalf of other signers. Assistants can fill in various field types such as text, checkboxes, dates, and more, streamlining the document preparation process before it reaches the final signers.

Changes Made

  • Added a new ASSISTANT recipient role to handle document preparation tasks.
  • Created specialized field components (e.g., AssistantCheckboxField, AssistantDateField) for assistants to prefill data.
  • Updated document recipient lists to display assistant contributions with a dedicated badge.
  • Modified document routing and field logic to support assistant pre-filled values.
  • Enhanced audit logs to track field prefilling actions by assistants.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1588 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 2/1/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/assistant-role` --- ### 📝 Commits (10+) - [`0bb0840`](https://github.com/documenso/documenso/commit/0bb0840d6061f41ff29fdbc5976d16b6fefdf1c8) chore: add assistant role - [`923e1fe`](https://github.com/documenso/documenso/commit/923e1fed7f2a60ed406a66d21d0783116336acd4) feat: add role - [`53216e6`](https://github.com/documenso/documenso/commit/53216e6438ad1b917ee445b2c3493dad51aadca5) chore: enable signing order on assitant role - [`d8b1f3c`](https://github.com/documenso/documenso/commit/d8b1f3c8176272af004c9dabe81d63ff941a7ef0) fix: correct signing order when assistant is sued - [`8e399d9`](https://github.com/documenso/documenso/commit/8e399d96aeef55a002d1580597c19d80f26a1609) chore: enforce signing order - [`809d1c5`](https://github.com/documenso/documenso/commit/809d1c5c3544e8eed27591ffcd0ce7f774a373e0) fix: signers sorting in assistant role - [`c8cab53`](https://github.com/documenso/documenso/commit/c8cab53020269605dfb5c6efb8a486369c7fb298) feat: show confirmation when disabling signing order with assistants - [`3160fbe`](https://github.com/documenso/documenso/commit/3160fbe9159fc3b5dc7a72c3e83f69b2e1b3757b) feat: filter assistant from adding fields - [`1c42507`](https://github.com/documenso/documenso/commit/1c4250769e51690c44954550f02e69550be34f8b) feat: add signer radio on assistant form - [`a2b46a4`](https://github.com/documenso/documenso/commit/a2b46a4826d3691eaf2a1242332ce11bc5dc4a73) feat: filter fields based on selected signer ### 📊 Changes **53 files changed** (+1633 additions, -695 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recipients.tsx` (+8 -1) 📝 `apps/web/src/app/(dashboard)/documents/move-document-dialog.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/templates/move-template-dialog.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx` (+5 -1) 📝 `apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx` (+3 -12) ➕ `apps/web/src/app/(signing)/sign/[token]/assistant/assistant-confirmation-dialog.tsx` (+73 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx` (+7 -10) 📝 `apps/web/src/app/(signing)/sign/[token]/date-field.tsx` (+7 -8) 📝 `apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx` (+7 -10) 📝 `apps/web/src/app/(signing)/sign/[token]/email-field.tsx` (+7 -5) 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+230 -94) 📝 `apps/web/src/app/(signing)/sign/[token]/initials-field.tsx` (+6 -9) 📝 `apps/web/src/app/(signing)/sign/[token]/name-field.tsx` (+10 -8) 📝 `apps/web/src/app/(signing)/sign/[token]/number-field.tsx` (+26 -14) 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+15 -4) 📝 `apps/web/src/app/(signing)/sign/[token]/radio-field.tsx` (+18 -6) ➕ `apps/web/src/app/(signing)/sign/[token]/recipient-context.tsx` (+66 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/signature-field.tsx` (+2 -4) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-field-container.tsx` (+1 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx` (+159 -140) _...and 33 more files_ </details> ### 📄 Description ## Demo https://github.com/user-attachments/assets/c1321578-47ec-405b-a70a-7d9578385895 ## Description Introduces the ability for users with the **Assistant** role to prefill fields on behalf of other signers. Assistants can fill in various field types such as text, checkboxes, dates, and more, streamlining the document preparation process before it reaches the final signers. ## Changes Made - Added a new `ASSISTANT` recipient role to handle document preparation tasks. - Created specialized field components (e.g., `AssistantCheckboxField`, `AssistantDateField`) for assistants to prefill data. - Updated document recipient lists to display assistant contributions with a dedicated badge. - Modified document routing and field logic to support assistant pre-filled values. - Enhanced audit logs to track field prefilling actions by assistants. ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:30:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1736
No description provided.