starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1537] [MERGED] fix: checkbox logic #1703

New issue

Closed

opened 2026-02-26 20:30:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:30:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1537
Author: @catalinpit
Created: 12/13/2024
Status: ✅ Merged
Merged: 12/23/2024
Merged by: @catalinpit

Base: main ← Head: fix/checkbox-values-logic

📝 Commits (8)

5e92628 fix: checkbox logic
59cfbc2 chore: backward compatibility
76ae648 fix: check logic for signed values
9d39b0c Merge branch 'main' into fix/checkbox-values-logic
9eff88a chore: improve code based on feedback
431a68b chore: trigger ci
265f509 Merge branch 'main' into fix/checkbox-values-logic
5e5f5c2 Merge branch 'main' into fix/checkbox-values-logic

📊 Changes

4 files changed (+36 additions, -7 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx (+10 -5)
📝 packages/lib/server-only/field/sign-field-with-token.ts (+3 -1)
📝 packages/lib/server-only/pdf/insert-field-in-pdf.ts (+2 -1)
➕ packages/lib/universal/field-checkbox.ts (+21 -0)

📄 Description

Description

Changes Made

Change 1
Change 2
...

Testing Performed

Tested feature X in scenario Y.
Ran unit tests for component Z.
Tested on browsers A, B, and C.
...

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1537 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 12/13/2024 **Status:** ✅ Merged **Merged:** 12/23/2024 **Merged by:** [@catalinpit](https://github.com/catalinpit) **Base:** `main` ← **Head:** `fix/checkbox-values-logic` --- ### 📝 Commits (8) - [`5e92628`](https://github.com/documenso/documenso/commit/5e92628a6baf4cb7720b412a177e7cbfe6ed37b2) fix: checkbox logic - [`59cfbc2`](https://github.com/documenso/documenso/commit/59cfbc2947698b5b3a4bcbc357f872c0284c3bd4) chore: backward compatibility - [`76ae648`](https://github.com/documenso/documenso/commit/76ae64869bb9d3bfb711107ebf6a147194d06dbd) fix: check logic for signed values - [`9d39b0c`](https://github.com/documenso/documenso/commit/9d39b0c774ac3c9f713a5c36a74a173802e0517e) Merge branch 'main' into fix/checkbox-values-logic - [`9eff88a`](https://github.com/documenso/documenso/commit/9eff88a0cb035f43233e705cfe7c4b922d796b3e) chore: improve code based on feedback - [`431a68b`](https://github.com/documenso/documenso/commit/431a68ba5e140cd11283e0ca545fe0e816ef8ca8) chore: trigger ci - [`265f509`](https://github.com/documenso/documenso/commit/265f50978c9829117d903e1131341ed49eaf07d0) Merge branch 'main' into fix/checkbox-values-logic - [`5e5f5c2`](https://github.com/documenso/documenso/commit/5e5f5c2496dcd8525c6ea0126b840c6f0f6d689e) Merge branch 'main' into fix/checkbox-values-logic ### 📊 Changes **4 files changed** (+36 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx` (+10 -5) 📝 `packages/lib/server-only/field/sign-field-with-token.ts` (+3 -1) 📝 `packages/lib/server-only/pdf/insert-field-in-pdf.ts` (+2 -1) ➕ `packages/lib/universal/field-checkbox.ts` (+21 -0) </details> ### 📄 Description ## Description   ## Related Issue   ## Changes Made   - Change 1 - Change 2 - ... ## Testing Performed   - Tested feature X in scenario Y. - Ran unit tests for component Z. - Tested on browsers A, B, and C. - ... ## Checklist   - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:30:42 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:08 +03:00

[PR #1703] [MERGED] chore: update d script in package.json #1803

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1703

No description provided.

Rows
Columns