[PR #1531] [CLOSED] fix: use khebab case for embedding css variables #1695

New issue

Closed

opened 2026-02-26 20:30:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:30:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1531
Author: @ephraimduncan
Created: 12/11/2024
Status: ❌ Closed

Base: main ← Head: fix/embed-whitelabel-colors

📝 Commits (3)

fd40873 fix: add unit to hsl colors in css conversion
50a7b59 fix: all variables with camel case not working
4f82241 fix: use khebab case

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 apps/web/src/app/embed/css-vars.ts (+2 -2)

📄 Description

Given the following CSS Variables,

  const cssVars = {
    primaryForeground: "#fff",
    primary: "#7f1d1d",
    radius: "2rem",
  };

This is how the embedding looks

Before

Current Production

After

Deployment for this PR

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1531 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 12/11/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/embed-whitelabel-colors` --- ### 📝 Commits (3) - [`fd40873`](https://github.com/documenso/documenso/commit/fd408732100803fc7c2e3598e36762f29bea2242) fix: add unit to hsl colors in css conversion - [`50a7b59`](https://github.com/documenso/documenso/commit/50a7b5937166ad80d7bcd3a75fab18aef382b251) fix: all variables with camel case not working - [`4f82241`](https://github.com/documenso/documenso/commit/4f822414cf5e726ed62613ad0d25043df8cbd6f3) fix: use khebab case ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/embed/css-vars.ts` (+2 -2) </details> ### 📄 Description Given the following CSS Variables, ```js const cssVars = { primaryForeground: "#fff", primary: "#7f1d1d", radius: "2rem", }; ``` This is how the embedding looks ### Before ![CleanShot 2024-12-11 at 16 06 34@2x](https://github.com/user-attachments/assets/3b91d347-4900-47fb-998f-98d1c6959dfb) [Current Production](https://stg-app.documenso.com/embed/direct/dgvlmj3braNVTACRJFbyL#JTdCJTIybmFtZSUyMiUzQSUyMkRpY3RhJTIwZXglMjBxdWlzJTIwZXN0JTIwbiUyMiUyQyUyMmxvY2tOYW1lJTIyJTNBdHJ1ZSUyQyUyMmVtYWlsJTIyJTNBJTIyZ2F0b2d5aCU0MG1haWxpbmF0b3IuY29tJTIyJTJDJTIybG9ja0VtYWlsJTIyJTNBdHJ1ZSUyQyUyMmNzc1ZhcnMlMjIlM0ElN0IlMjJwcmltYXJ5Rm9yZWdyb3VuZCUyMiUzQSUyMiUyM2ZmZiUyMiUyQyUyMnByaW1hcnklMjIlM0ElMjIlMjM3ZjFkMWQlMjIlMkMlMjJyYWRpdXMlMjIlM0ElMjIycmVtJTIyJTdEJTdE) ### After ![CleanShot 2024-12-11 at 16 07 00@2x](https://github.com/user-attachments/assets/9e23639f-2af3-4dd0-a768-5be2cace3a77) [Deployment for this PR](https://stg-app-git-fix-embed-whitelabel-colors-documenso.vercel.app/embed/direct/0QZo7ial78RoelGRAPyp6#JTdCJTIybmFtZSUyMiUzQSUyMkRpY3RhJTIwZXglMjBxdWlzJTIwZXN0JTIwbiUyMiUyQyUyMmxvY2tOYW1lJTIyJTNBdHJ1ZSUyQyUyMmVtYWlsJTIyJTNBJTIyZ2F0b2d5aCU0MG1haWxpbmF0b3IuY29tJTIyJTJDJTIybG9ja0VtYWlsJTIyJTNBdHJ1ZSUyQyUyMmNzc1ZhcnMlMjIlM0ElN0IlMjJwcmltYXJ5Rm9yZWdyb3VuZCUyMiUzQSUyMiUyM2ZmZiUyMiUyQyUyMnByaW1hcnklMjIlM0ElMjIlMjM3ZjFkMWQlMjIlMkMlMjJyYWRpdXMlMjIlM0ElMjIycmVtJTIyJTdEJTdE) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:30:40 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1695

No description provided.

Rows
Columns