[PR #1519] [CLOSED] Fix/dark mode for radio button and checkbox #1686

Closed
opened 2026-02-26 20:30:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1519
Author: @anandrajsingh
Created: 12/7/2024
Status: Closed

Base: mainHead: fix/dark-mode-for-radio-button-and-checkbox


📝 Commits (2)

  • 3c0e807 fix: for darkmode on radio button and checkbox
  • c47f128 fix: for radio button and checkbox in signing page

📊 Changes

4 files changed (+8 additions, -8 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx (+2 -2)
📝 apps/web/src/app/(signing)/sign/[token]/radio-field.tsx (+2 -2)
📝 packages/ui/primitives/document-flow/advanced-fields/checkbox.tsx (+2 -2)
📝 packages/ui/primitives/document-flow/advanced-fields/radio.tsx (+2 -2)

📄 Description


Description

Radio-button and checkbox css was not working properly on documents editing page and signing page

#1513

Changes Made

Signing page changes

  • apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx - Checkbox
  • apps/web/src/app/(signing)/sign/[token]/radio-field.tsx - Radio-button

Edit page changes

  • packages/ui/primitives/document-flow/advanced-fields/checkbox.tsx - Checkbox
  • packages/ui/primitives/document-flow/advanced-fields/radio-field.tsx - Radio-button

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Other than issue #1513 it also changes the signing page bug


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1519 **Author:** [@anandrajsingh](https://github.com/anandrajsingh) **Created:** 12/7/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/dark-mode-for-radio-button-and-checkbox` --- ### 📝 Commits (2) - [`3c0e807`](https://github.com/documenso/documenso/commit/3c0e8074a716c3933219f90e764620e2924b8a69) fix: for darkmode on radio button and checkbox - [`c47f128`](https://github.com/documenso/documenso/commit/c47f1285e4187197d20c29bb490d124b08c480d5) fix: for radio button and checkbox in signing page ### 📊 Changes **4 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx` (+2 -2) 📝 `apps/web/src/app/(signing)/sign/[token]/radio-field.tsx` (+2 -2) 📝 `packages/ui/primitives/document-flow/advanced-fields/checkbox.tsx` (+2 -2) 📝 `packages/ui/primitives/document-flow/advanced-fields/radio.tsx` (+2 -2) </details> ### 📄 Description --- ## Description Radio-button and checkbox css was not working properly on documents editing page and signing page <!--- Describe the changes introduced by this pull request. --> <!--- Explain what problem it solves or what feature/fix it adds. --> ## Related Issue #1513 <!--- If this pull request is related to a specific issue, reference it here using #issue_number. --> <!--- For example, "Fixes #123" or "Addresses #456". --> ## Changes Made <!--- Provide a summary of the changes made in this pull request. --> <!--- Include any relevant technical details or architecture changes. --> **Signing page changes** - `apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx` - Checkbox - `apps/web/src/app/(signing)/sign/[token]/radio-field.tsx` - Radio-button **Edit page changes** - `packages/ui/primitives/document-flow/advanced-fields/checkbox.tsx` - Checkbox - `packages/ui/primitives/document-flow/advanced-fields/radio-field.tsx` - Radio-button ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes Other than issue #1513 it also changes the signing page bug <!--- Provide any additional context or notes for the reviewers. --> <!--- This might include details about design decisions, potential concerns, or anything else relevant. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:30:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1686
No description provided.