[PR #1515] [MERGED] fix: prevent accidental signatures #1685

New issue

Closed

opened 2026-02-26 20:30:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:30:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1515
Author: @ephraimduncan
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/8/2024
Merged by: @Mythie

Base: main ← Head: fix/accidental-signatures

📝 Commits (10+)

d5e0f82 wip
0ffde5a chore: wip
cde0ec5 fix: signature field dialog opening when signature is less than 1%
e67e1c2 fix: merge conflicts
7257aaa fix: use existing signature
d9aa345 fix: conflicts
125afd7 fix: po file merge conflicts
9860a3e fix: add min coverage validation to relevant signing areas
1e3a4b4 chore: update tests
2637212 chore: update tests

📊 Changes

23 files changed (+443 additions, -292 deletions)

View changed files

📝 .devcontainer/devcontainer.json (+2 -8)
📝 apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx (+1 -1)
📝 apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx (+8 -4)
📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+25 -5)
📝 apps/web/src/app/(signing)/sign/[token]/provider.tsx (+5 -0)
📝 apps/web/src/app/(signing)/sign/[token]/signature-field.tsx (+26 -11)
📝 apps/web/src/app/embed/direct/[[...url]]/client.tsx (+27 -2)
📝 apps/web/src/app/embed/sign/[[...url]]/client.tsx (+28 -3)
📝 packages/app-tests/e2e/document-auth/action-auth.spec.ts (+8 -8)
📝 packages/app-tests/e2e/document-flow/stepper-component.spec.ts (+9 -4)
📝 packages/app-tests/e2e/features/include-document-certificate.spec.ts (+6 -6)
📝 packages/app-tests/e2e/user/auth-flow.spec.ts (+2 -3)
📝 packages/app-tests/e2e/user/update-name.spec.ts (+1 -9)
📝 packages/lib/translations/de/common.po (+11 -11)
📝 packages/lib/translations/de/web.po (+52 -45)
📝 packages/lib/translations/en/common.po (+11 -11)
📝 packages/lib/translations/en/web.po (+52 -45)
📝 packages/lib/translations/es/common.po (+11 -11)
📝 packages/lib/translations/es/web.po (+52 -45)
📝 packages/lib/translations/fr/common.po (+11 -11)

...and 3 more files

📄 Description

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1515 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/8/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/accidental-signatures` --- ### 📝 Commits (10+) - [`d5e0f82`](https://github.com/documenso/documenso/commit/d5e0f826349ebcfe1ca8acf3f51f22ff0b4392ab) wip - [`0ffde5a`](https://github.com/documenso/documenso/commit/0ffde5a38708c53fed8701fc16a8e34bac8e453b) chore: wip - [`cde0ec5`](https://github.com/documenso/documenso/commit/cde0ec5544567fbc7fdf2430327a40db2459c4a9) fix: signature field dialog opening when signature is less than 1% - [`e67e1c2`](https://github.com/documenso/documenso/commit/e67e1c2684c91521376418a101385f7636fe4b1b) fix: merge conflicts - [`7257aaa`](https://github.com/documenso/documenso/commit/7257aaa7500adae2b20679e3204dac52a0e8fc4c) fix: use existing signature - [`d9aa345`](https://github.com/documenso/documenso/commit/d9aa3451af5f0aef0ac81b18c3d2a9177a14e503) fix: conflicts - [`125afd7`](https://github.com/documenso/documenso/commit/125afd71817eab5957b9c12d64e47d359679c7b0) fix: po file merge conflicts - [`9860a3e`](https://github.com/documenso/documenso/commit/9860a3e4e58f31d15e24a4fa6a22f8e74a9015f8) fix: add min coverage validation to relevant signing areas - [`1e3a4b4`](https://github.com/documenso/documenso/commit/1e3a4b4635636458e3ff092974c5ef4b76ad3a34) chore: update tests - [`2637212`](https://github.com/documenso/documenso/commit/2637212d7ebc6d1b749310831583e8c605c491a0) chore: update tests ### 📊 Changes **23 files changed** (+443 additions, -292 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/devcontainer.json` (+2 -8) 📝 `apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx` (+1 -1) 📝 `apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx` (+8 -4) 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+25 -5) 📝 `apps/web/src/app/(signing)/sign/[token]/provider.tsx` (+5 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/signature-field.tsx` (+26 -11) 📝 `apps/web/src/app/embed/direct/[[...url]]/client.tsx` (+27 -2) 📝 `apps/web/src/app/embed/sign/[[...url]]/client.tsx` (+28 -3) 📝 `packages/app-tests/e2e/document-auth/action-auth.spec.ts` (+8 -8) 📝 `packages/app-tests/e2e/document-flow/stepper-component.spec.ts` (+9 -4) 📝 `packages/app-tests/e2e/features/include-document-certificate.spec.ts` (+6 -6) 📝 `packages/app-tests/e2e/user/auth-flow.spec.ts` (+2 -3) 📝 `packages/app-tests/e2e/user/update-name.spec.ts` (+1 -9) 📝 `packages/lib/translations/de/common.po` (+11 -11) 📝 `packages/lib/translations/de/web.po` (+52 -45) 📝 `packages/lib/translations/en/common.po` (+11 -11) 📝 `packages/lib/translations/en/web.po` (+52 -45) 📝 `packages/lib/translations/es/common.po` (+11 -11) 📝 `packages/lib/translations/es/web.po` (+52 -45) 📝 `packages/lib/translations/fr/common.po` (+11 -11) _...and 3 more files_ </details> ### 📄 Description ![CleanShot 2024-12-06 at 03 30 39](https://github.com/user-attachments/assets/d47dc820-f19d-43b7-a60d-914fc9ab24b8) ![CleanShot 2024-12-06 at 03 32 34](https://github.com/user-attachments/assets/0db98735-8c91-469b-873c-adb19d0fff7b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:30:35 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:05 +03:00

[PR #1685] [MERGED] fix: duplicate field bugs #1792

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1685

No description provided.

Rows
Columns