[PR #1497] [MERGED] fix: wrong signing invitation message #1673

Closed
opened 2026-02-26 19:34:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1497
Author: @catalinpit
Created: 11/29/2024
Status: Merged
Merged: 12/1/2024
Merged by: @Mythie

Base: mainHead: fix/team-invitation-message


📝 Commits (5)

📊 Changes

6 files changed (+69 additions, -31 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx (+44 -19)
📝 packages/email/template-components/template-document-invite.tsx (+1 -1)
📝 packages/email/templates/document-invite.tsx (+11 -9)
📝 packages/lib/jobs/definitions/emails/send-signing-email.ts (+1 -1)
📝 packages/lib/server-only/document/get-document-by-token.ts (+11 -0)
📝 packages/lib/server-only/document/resend-document.tsx (+1 -1)

📄 Description

Description

Fix the wrong message on the signing pages and emails.

After - Team account

Send on Behalf of Team enabled

CleanShot 2024-11-29 at 15 06 16

Send on Behalf of Team disabled

CleanShot 2024-11-29 at 15 06 51

After - Personal account

CleanShot 2024-11-29 at 15 07 20

After - Personal account email invite

CleanShot 2024-11-29 at 15 15 27@2x

After - Team account email invite Send on Behalf of Team enabled

CleanShot 2024-11-29 at 15 17 24@2x

After - Team account email invite Send on Behalf of Team disabled

CleanShot 2024-11-29 at 15 20 23@2x


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1497 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 11/29/2024 **Status:** ✅ Merged **Merged:** 12/1/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/team-invitation-message` --- ### 📝 Commits (5) - [`e0fdde1`](https://github.com/documenso/documenso/commit/e0fdde13a699cd7fc8a8d3ef513f498f93473759) fix: wrong signing invitation message - [`77a6cd8`](https://github.com/documenso/documenso/commit/77a6cd8824264a29f47d0b43eb72d66c519ef8e7) fix: wrong name in team invite - [`d08903b`](https://github.com/documenso/documenso/commit/d08903ba5cf4096df45a3c2919421f4109548287) fix: add quotes - [`43a9a5b`](https://github.com/documenso/documenso/commit/43a9a5bee841773234b2f2adbf16dec486eb622a) fix: tidy ternaries - [`357ad7d`](https://github.com/documenso/documenso/commit/357ad7d70b4dbf534e4433339c8e2d00460ee9d1) fix: update styling ### 📊 Changes **6 files changed** (+69 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx` (+44 -19) 📝 `packages/email/template-components/template-document-invite.tsx` (+1 -1) 📝 `packages/email/templates/document-invite.tsx` (+11 -9) 📝 `packages/lib/jobs/definitions/emails/send-signing-email.ts` (+1 -1) 📝 `packages/lib/server-only/document/get-document-by-token.ts` (+11 -0) 📝 `packages/lib/server-only/document/resend-document.tsx` (+1 -1) </details> ### 📄 Description ## Description Fix the wrong message on the signing pages and emails. ## After - Team account ### `Send on Behalf of Team` enabled ![CleanShot 2024-11-29 at 15 06 16](https://github.com/user-attachments/assets/e20f61aa-7d8a-428b-814a-2a33ead0988f) ### `Send on Behalf of Team` disabled ![CleanShot 2024-11-29 at 15 06 51](https://github.com/user-attachments/assets/2229e6e6-dc4b-490d-aa71-10701504976e) ## After - Personal account ![CleanShot 2024-11-29 at 15 07 20](https://github.com/user-attachments/assets/58e8b0aa-187d-4d40-9ca1-3572c2da9bef) ## After - Personal account email invite ![CleanShot 2024-11-29 at 15 15 27@2x](https://github.com/user-attachments/assets/db908913-e965-4d5a-bf5f-a20caba7eb95) ## After - Team account email invite `Send on Behalf of Team` enabled ![CleanShot 2024-11-29 at 15 17 24@2x](https://github.com/user-attachments/assets/d85b0f1d-7b74-4c8c-8301-bd9003d44a1e) ## After - Team account email invite `Send on Behalf of Team` disabled ![CleanShot 2024-11-29 at 15 20 23@2x](https://github.com/user-attachments/assets/95befa6d-9d01-4519-b7cb-f5a109dfda92) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:34:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1673
No description provided.