[PR #1496] [MERGED] feat: upload signature as img #1672

Closed
opened 2026-02-26 19:34:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1496
Author: @catalinpit
Created: 11/28/2024
Status: Merged
Merged: 12/4/2024
Merged by: @Mythie

Base: mainHead: feat/add-image-as-signature


📝 Commits (10+)

  • 46cc55a feat: upload signature as img
  • 6b65242 Merge branch 'main' into feat/add-image-as-signature
  • 2904bef chore: handle image upload
  • 4667e4a chore: fix issue with typed signature storing the base64 string
  • f92c03f chore: split the image upload handle function into multiple functions
  • c33c27d fix: issue when uploading a signature over a typed signature
  • 33e0904 Merge branch 'main' into feat/add-image-as-signature
  • 592ffad Merge branch 'main' into feat/add-image-as-signature
  • 41227ed chore: implement feedback
  • ef029b4 Merge branch 'main' into feat/add-image-as-signature

📊 Changes

1 file changed (+116 additions, -5 deletions)

View changed files

📝 packages/ui/primitives/signature-pad/signature-pad.tsx (+116 -5)

📄 Description

Allow users to upload their signature as an image.

https://github.com/user-attachments/assets/375faad2-f0db-4f44-83d2-d969c5ab4442


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1496 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 11/28/2024 **Status:** ✅ Merged **Merged:** 12/4/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/add-image-as-signature` --- ### 📝 Commits (10+) - [`46cc55a`](https://github.com/documenso/documenso/commit/46cc55a3a7a01bd5379d68bbcb967be38d875404) feat: upload signature as img - [`6b65242`](https://github.com/documenso/documenso/commit/6b6524251987c008b3ad9740d295688c1b71552a) Merge branch 'main' into feat/add-image-as-signature - [`2904bef`](https://github.com/documenso/documenso/commit/2904beffe31c5ec4e692430463867985d62a226a) chore: handle image upload - [`4667e4a`](https://github.com/documenso/documenso/commit/4667e4a08b296147bd9af99b0cdafda44400ff6d) chore: fix issue with typed signature storing the base64 string - [`f92c03f`](https://github.com/documenso/documenso/commit/f92c03fcf7701eee1b306b257d7586130a5f2767) chore: split the image upload handle function into multiple functions - [`c33c27d`](https://github.com/documenso/documenso/commit/c33c27dfc52e968d1aaa7e0bc4fb65bbc47a183a) fix: issue when uploading a signature over a typed signature - [`33e0904`](https://github.com/documenso/documenso/commit/33e09044bc257b017b1cb17a1421618b301ce19b) Merge branch 'main' into feat/add-image-as-signature - [`592ffad`](https://github.com/documenso/documenso/commit/592ffadaff8bf72242b546ebf5af7a78db4b2669) Merge branch 'main' into feat/add-image-as-signature - [`41227ed`](https://github.com/documenso/documenso/commit/41227ed65852f74cd448c3c1644412c7e2713f57) chore: implement feedback - [`ef029b4`](https://github.com/documenso/documenso/commit/ef029b4558a6cacb988670b6d0059735ccc97ea6) Merge branch 'main' into feat/add-image-as-signature ### 📊 Changes **1 file changed** (+116 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/primitives/signature-pad/signature-pad.tsx` (+116 -5) </details> ### 📄 Description Allow users to upload their signature as an image. https://github.com/user-attachments/assets/375faad2-f0db-4f44-83d2-d969c5ab4442 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:34:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1672
No description provided.