[PR #1487] [MERGED] fix: hardcode delete confirmation text to avoid translation mismatch #1665

New issue

Closed

opened 2026-02-26 19:34:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1487
Author: @ephraimduncan
Created: 11/20/2024
Status: ✅ Merged
Merged: 11/22/2024
Merged by: @dguyen

Base: main ← Head: fix/delete-document-input

📝 Commits (6)

a88cf04 fix: hardcode delete confirmation text to avoid translation mismatch
1575a03 Merge branch 'main' into fix/delete-document-input
cbc357e Merge branch 'main' into fix/delete-document-input
da8c85f fix: change wording to avoid having 'delete' in german transalation
051c7a7 Merge branch 'main' into fix/delete-document-input
9948500 fix: translations

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx (+4 -2)

📄 Description

Summary by CodeRabbit

New Features
- Updated placeholder text in the Delete Document dialog to provide clearer instructions: "To confirm delete, type: delete".
Bug Fixes
- Enhanced input validation for the delete action in the Delete Document dialog, ensuring a smoother user experience.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1487 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 11/20/2024 **Status:** ✅ Merged **Merged:** 11/22/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/delete-document-input` --- ### 📝 Commits (6) - [`a88cf04`](https://github.com/documenso/documenso/commit/a88cf04ba62b9f78e15a6a3d2a476fb531a17072) fix: hardcode delete confirmation text to avoid translation mismatch - [`1575a03`](https://github.com/documenso/documenso/commit/1575a034244028b3b6cbe843b1e8ed88c64d52fc) Merge branch 'main' into fix/delete-document-input - [`cbc357e`](https://github.com/documenso/documenso/commit/cbc357ef742f37df8107bbf1feb53b9936b4118a) Merge branch 'main' into fix/delete-document-input - [`da8c85f`](https://github.com/documenso/documenso/commit/da8c85fbb9019a557ac01ce420d584cc4067b46a) fix: change wording to avoid having 'delete' in german transalation - [`051c7a7`](https://github.com/documenso/documenso/commit/051c7a74155ac27b2673228f84342f001bbe7f86) Merge branch 'main' into fix/delete-document-input - [`9948500`](https://github.com/documenso/documenso/commit/9948500d5715a8ab4e5a44183753636095446834) fix: translations ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx` (+4 -2) </details> ### 📄 Description  ## Summary by CodeRabbit - **New Features** - Updated placeholder text in the Delete Document dialog to provide clearer instructions: "To confirm delete, type: delete". - **Bug Fixes** - Enhanced input validation for the delete action in the Delete Document dialog, ensuring a smoother user experience.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:13 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1665

No description provided.

Rows
Columns