starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1484] [MERGED] feat: automatically sign fields in large documents #1661

New issue

Closed

opened 2026-02-26 19:34:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1484
Author: @Mythie
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @Mythie

Base: main ← Head: feat/auto-sign

📝 Commits (1)

c62f57d feat: automatically sign fields in large documents

📊 Changes

15 files changed (+401 additions, -54 deletions)

View changed files

➕ apps/web/src/app/(signing)/sign/[token]/auto-sign.tsx (+237 -0)
📝 apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx (+3 -0)
📝 packages/lib/translations/de/common.po (+6 -1)
📝 packages/lib/translations/de/marketing.po (+0 -1)
📝 packages/lib/translations/de/web.po (+33 -11)
📝 packages/lib/translations/en/common.po (+6 -0)
📝 packages/lib/translations/en/web.po (+33 -10)
📝 packages/lib/translations/es/common.po (+6 -1)
📝 packages/lib/translations/es/marketing.po (+0 -1)
📝 packages/lib/translations/es/web.po (+33 -11)
📝 packages/lib/translations/fr/common.po (+6 -1)
📝 packages/lib/translations/fr/marketing.po (+0 -1)
📝 packages/lib/translations/fr/web.po (+33 -11)
📝 packages/ui/primitives/dialog.tsx (+1 -1)
📝 packages/ui/primitives/document-flow/types.ts (+4 -4)

📄 Description

Description

Adds a dialog that will display when a certain field threshold is reached asking the user if they would like to sign non-critical fields such as name, date, initials, and email with information that is already available.

This has not been added to direct templates since we would often not have all the pre-requisite knowledge since users are mostly anonymous. Additionally, this has not been added to the embedding view since it may detract from the experience for some.

Will not prompt the user if there is action authentication on the document.

See the below demo:

https://github.com/user-attachments/assets/71739b5c-1323-4da9-89fd-a1145c9714d5

#1281 (Older PR relating to the feature)

Changes Made

Added a new auto-sign dialog that will automatically trigger once certain criteria is met.

Testing Performed

Tested that the dialog displays when the threshold is met
Tested that the dialog is hidden when the threshold is not met
Tested that the messaging during errors is correct
Tested that the dialog does not display when 2FA or Passkeys are required

Summary by CodeRabbit

New Features
- Introduced the AutoSign component for automatic signing of document fields based on user information.
- Enhanced the SigningPageView to include the AutoSign component, improving user experience during document signing.
Translations
- Updated German, Spanish, French, and English translations for various user interface elements and marketing content to improve clarity and accuracy.
- Added new translation entries for recently introduced features, including auto-signing functionality.
Bug Fixes
- Improved error handling during the signing process with user notifications for any failures.
Style
- Enhanced the Dialog component for better customization options regarding positioning and visibility of the close button.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1484 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/auto-sign` --- ### 📝 Commits (1) - [`c62f57d`](https://github.com/documenso/documenso/commit/c62f57d2edcecabced957fa2bdc3e06cb02df448) feat: automatically sign fields in large documents ### 📊 Changes **15 files changed** (+401 additions, -54 deletions) <details> <summary>View changed files</summary> ➕ `apps/web/src/app/(signing)/sign/[token]/auto-sign.tsx` (+237 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx` (+3 -0) 📝 `packages/lib/translations/de/common.po` (+6 -1) 📝 `packages/lib/translations/de/marketing.po` (+0 -1) 📝 `packages/lib/translations/de/web.po` (+33 -11) 📝 `packages/lib/translations/en/common.po` (+6 -0) 📝 `packages/lib/translations/en/web.po` (+33 -10) 📝 `packages/lib/translations/es/common.po` (+6 -1) 📝 `packages/lib/translations/es/marketing.po` (+0 -1) 📝 `packages/lib/translations/es/web.po` (+33 -11) 📝 `packages/lib/translations/fr/common.po` (+6 -1) 📝 `packages/lib/translations/fr/marketing.po` (+0 -1) 📝 `packages/lib/translations/fr/web.po` (+33 -11) 📝 `packages/ui/primitives/dialog.tsx` (+1 -1) 📝 `packages/ui/primitives/document-flow/types.ts` (+4 -4) </details> ### 📄 Description ## Description Adds a dialog that will display when a certain field threshold is reached asking the user if they would like to sign non-critical fields such as name, date, initials, and email with information that is already available. This has not been added to direct templates since we would often not have all the pre-requisite knowledge since users are mostly anonymous. Additionally, this has not been added to the embedding view since it may detract from the experience for some. Will not prompt the user if there is action authentication on the document. See the below demo: https://github.com/user-attachments/assets/71739b5c-1323-4da9-89fd-a1145c9714d5 ## Related Issue #1281 (Older PR relating to the feature) ## Changes Made - Added a new auto-sign dialog that will automatically trigger once certain criteria is met. ## Testing Performed - Tested that the dialog displays when the threshold is met - Tested that the dialog is hidden when the threshold is not met - Tested that the messaging during errors is correct - Tested that the dialog does not display when 2FA or Passkeys are required  ## Summary by CodeRabbit - **New Features** - Introduced the `AutoSign` component for automatic signing of document fields based on user information. - Enhanced the `SigningPageView` to include the `AutoSign` component, improving user experience during document signing. - **Translations** - Updated German, Spanish, French, and English translations for various user interface elements and marketing content to improve clarity and accuracy. - Added new translation entries for recently introduced features, including auto-signing functionality. - **Bug Fixes** - Improved error handling during the signing process with user notifications for any failures. - **Style** - Enhanced the `Dialog` component for better customization options regarding positioning and visibility of the close button.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:13 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1661

No description provided.

Rows
Columns