starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1472] [MERGED] feat: signature rejection #1654

New issue

Closed

opened 2026-02-26 19:34:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1472
Author: @Mythie
Created: 11/14/2024
Status: ✅ Merged
Merged: 11/14/2024
Merged by: @Mythie

Base: main ← Head: feat/signature-rejection

📝 Commits (3)

e9fef42 feat: signature rejection
aa916d2 fix: remove compiled translation files
3875c49 Merge branch 'main' into feat/signature-rejection

📊 Changes

44 files changed (+1595 additions, -226 deletions)

View changed files

📝 .github/workflows/publish.yml (+1 -1)
📝 apps/marketing/src/app/(marketing)/singleplayer/client.tsx (+1 -0)
📝 apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recent-activity.tsx (+6 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recipients.tsx (+30 -1)
📝 apps/web/src/app/(dashboard)/documents/data-table.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+4 -0)
➕ apps/web/src/app/(signing)/sign/[token]/reject-document-dialog.tsx (+170 -0)
➕ apps/web/src/app/(signing)/sign/[token]/rejected/page.tsx (+110 -0)
📝 apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx (+26 -21)
📝 apps/web/src/components/(dashboard)/avatar/stack-avatar.tsx (+11 -5)
📝 apps/web/src/components/(dashboard)/avatar/stack-avatars-with-tooltip.tsx (+41 -2)
📝 apps/web/src/components/document/document-history-sheet.tsx (+1 -0)
📝 packages/email/template-components/template-document-invite.tsx (+17 -0)
➕ packages/email/template-components/template-document-rejected.tsx (+48 -0)
➕ packages/email/template-components/template-document-rejection-confirmed.tsx (+48 -0)
➕ packages/email/templates/document-rejected.tsx (+70 -0)
➕ packages/email/templates/document-rejection-confirmed.tsx (+70 -0)
📝 packages/lib/client-only/recipient-type.ts (+5 -0)
📝 packages/lib/jobs/client.ts (+2 -0)
➕ packages/lib/jobs/definitions/emails/send-rejection-emails.ts (+169 -0)

...and 24 more files

📄 Description

Description

Adds support for rejecting a given document informing the document owner.

Flows for resolving a rejection don't currently exist so it's up to the document owner to reach out to the recipient and work out a way to move forward via a new document or offline agreement.

Changes Made

Added new rejection properties to the recipient schema
Added API endpoints to support rejection
Added email templates for notifying the document owner and recipient
Added a dialog on the signing page to start the rejection flow.

Testing Performed

Manually tested the flow end to end
Automated tests are planned

Summary by CodeRabbit

Release Notes

New Features
- Introduced a document rejection feature, allowing recipients to reject documents and provide reasons.
- Added visual indicators for rejected documents in the dashboard and recipient views.
- Implemented a rejection confirmation dialog for users when rejecting documents.
- Enhanced email templates to notify users of document rejections.
- New audit log entries for tracking document rejection events.
Bug Fixes
- Improved error handling for document rejection scenarios.
Documentation
- Updated translation files to include new terms related to document rejection in multiple languages.

These updates enhance user interaction and provide clearer feedback regarding document statuses.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1472 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/signature-rejection` --- ### 📝 Commits (3) - [`e9fef42`](https://github.com/documenso/documenso/commit/e9fef42aad440e97f6b6b4e2d584e29eabe7122c) feat: signature rejection - [`aa916d2`](https://github.com/documenso/documenso/commit/aa916d2114a4fb59f6a50f1c67623cfb310a845d) fix: remove compiled translation files - [`3875c49`](https://github.com/documenso/documenso/commit/3875c494a4923f32f50fbb67917a003c54f1ba3f) Merge branch 'main' into feat/signature-rejection ### 📊 Changes **44 files changed** (+1595 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish.yml` (+1 -1) 📝 `apps/marketing/src/app/(marketing)/singleplayer/client.tsx` (+1 -0) 📝 `apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recent-activity.tsx` (+6 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recipients.tsx` (+30 -1) 📝 `apps/web/src/app/(dashboard)/documents/data-table.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+4 -0) ➕ `apps/web/src/app/(signing)/sign/[token]/reject-document-dialog.tsx` (+170 -0) ➕ `apps/web/src/app/(signing)/sign/[token]/rejected/page.tsx` (+110 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx` (+26 -21) 📝 `apps/web/src/components/(dashboard)/avatar/stack-avatar.tsx` (+11 -5) 📝 `apps/web/src/components/(dashboard)/avatar/stack-avatars-with-tooltip.tsx` (+41 -2) 📝 `apps/web/src/components/document/document-history-sheet.tsx` (+1 -0) 📝 `packages/email/template-components/template-document-invite.tsx` (+17 -0) ➕ `packages/email/template-components/template-document-rejected.tsx` (+48 -0) ➕ `packages/email/template-components/template-document-rejection-confirmed.tsx` (+48 -0) ➕ `packages/email/templates/document-rejected.tsx` (+70 -0) ➕ `packages/email/templates/document-rejection-confirmed.tsx` (+70 -0) 📝 `packages/lib/client-only/recipient-type.ts` (+5 -0) 📝 `packages/lib/jobs/client.ts` (+2 -0) ➕ `packages/lib/jobs/definitions/emails/send-rejection-emails.ts` (+169 -0) _...and 24 more files_ </details> ### 📄 Description ## Description Adds support for rejecting a given document informing the document owner. Flows for resolving a rejection don't currently exist so it's up to the document owner to reach out to the recipient and work out a way to move forward via a new document or offline agreement. ## Related Issue ## Changes Made - Added new rejection properties to the recipient schema - Added API endpoints to support rejection - Added email templates for notifying the document owner and recipient - Added a dialog on the signing page to start the rejection flow. ## Testing Performed - Manually tested the flow end to end - Automated tests are planned  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced a document rejection feature, allowing recipients to reject documents and provide reasons. - Added visual indicators for rejected documents in the dashboard and recipient views. - Implemented a rejection confirmation dialog for users when rejecting documents. - Enhanced email templates to notify users of document rejections. - New audit log entries for tracking document rejection events. - **Bug Fixes** - Improved error handling for document rejection scenarios. - **Documentation** - Updated translation files to include new terms related to document rejection in multiple languages. These updates enhance user interaction and provide clearer feedback regarding document statuses.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:11 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1654

No description provided.

Rows
Columns