[PR #1470] [MERGED] feat: enable optional fields #1652

New issue

Closed

opened 2026-02-26 19:34:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1470
Author: @catalinpit
Created: 11/13/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @dguyen

Base: main ← Head: fix/optional-fields-required

📝 Commits (10+)

ef67a70 feat: enable optional fields
af368fd fix: optional fields
456904e chore: refactor code and extract advanced field check
b4d79b4 chore: backend checks
24f13a0 chore: make it work properly
c039d96 Merge branch 'main' into fix/optional-fields-required
073a1c1 chore: use the advanced field function
e409a63 chore: last fixes
f1eacbd chore: implement pr feedback
09973c6 chore: merge main

📊 Changes

7 files changed (+76 additions, -13 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+10 -4)
📝 apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx (+3 -2)
📝 packages/lib/jobs/definitions/internal/seal-document.handler.ts (+6 -3)
📝 packages/lib/server-only/document/complete-document-with-token.ts (+2 -1)
📝 packages/lib/server-only/document/seal-document.ts (+3 -2)
➕ packages/lib/utils/advanced-fields-helpers.ts (+51 -0)
📝 packages/ui/primitives/template-flow/add-template-settings.tsx (+1 -1)

📄 Description

fixes #1389

Summary by CodeRabbit

Release Notes

New Features
- Enhanced validation logic for form fields in the signing process, ensuring only relevant fields are checked.
- Improved completion status determination for signing fields, accommodating optional advanced fields.
- Added advanced field type checks to streamline document sealing and signing processes.
Bug Fixes
- Refined error messages for unsigned fields to clarify issues related to recipients.
Documentation
- Updated comments for better understanding of validation logic and field handling.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1470 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/optional-fields-required` --- ### 📝 Commits (10+) - [`ef67a70`](https://github.com/documenso/documenso/commit/ef67a70684a847a5fec1ae53645eca41902768dd) feat: enable optional fields - [`af368fd`](https://github.com/documenso/documenso/commit/af368fd611bff72fc00ab9ab2a77d80113a4fbe2) fix: optional fields - [`456904e`](https://github.com/documenso/documenso/commit/456904e0241ea4d23c710404ecfa4d16f0face35) chore: refactor code and extract advanced field check - [`b4d79b4`](https://github.com/documenso/documenso/commit/b4d79b4e5964ca04abfd2ef19feacd74b22ae0fc) chore: backend checks - [`24f13a0`](https://github.com/documenso/documenso/commit/24f13a00536aad24ddc2824b2934710de0ad223b) chore: make it work properly - [`c039d96`](https://github.com/documenso/documenso/commit/c039d966087ee38e653e0553638069da33679d2a) Merge branch 'main' into fix/optional-fields-required - [`073a1c1`](https://github.com/documenso/documenso/commit/073a1c179bb501ac615d5c156838d60a1b511e83) chore: use the advanced field function - [`e409a63`](https://github.com/documenso/documenso/commit/e409a632605026deef380cb59657f89f58063eb2) chore: last fixes - [`f1eacbd`](https://github.com/documenso/documenso/commit/f1eacbd3633a76b7d9b56eeeddc6426177b7e125) chore: implement pr feedback - [`09973c6`](https://github.com/documenso/documenso/commit/09973c6f43be79afdb0305472da952c88b049168) chore: merge main ### 📊 Changes **7 files changed** (+76 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+10 -4) 📝 `apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx` (+3 -2) 📝 `packages/lib/jobs/definitions/internal/seal-document.handler.ts` (+6 -3) 📝 `packages/lib/server-only/document/complete-document-with-token.ts` (+2 -1) 📝 `packages/lib/server-only/document/seal-document.ts` (+3 -2) ➕ `packages/lib/utils/advanced-fields-helpers.ts` (+51 -0) 📝 `packages/ui/primitives/template-flow/add-template-settings.tsx` (+1 -1) </details> ### 📄 Description fixes #1389  ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced validation logic for form fields in the signing process, ensuring only relevant fields are checked. - Improved completion status determination for signing fields, accommodating optional advanced fields. - Added advanced field type checks to streamline document sealing and signing processes. - **Bug Fixes** - Refined error messages for unsigned fields to clarify issues related to recipients. - **Documentation** - Updated comments for better understanding of validation logic and field handling.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:10 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:00 +03:00

[PR #1652] [MERGED] fix: signing field disabled when pointer is out of canvas #1771

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1652

No description provided.

Rows
Columns