[PR #1436] [MERGED] chore: enable typed signature by default #1628

New issue

Closed

opened 2026-02-26 19:34:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1436
Author: @catalinpit
Created: 11/1/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @Mythie

Base: main ← Head: feat/typed-signature-updates

📝 Commits (10+)

b7bb303 fix: enable typed signatures by default
e3be2ed Revert "fix: enable typed signatures by default"
0d6987e fix: revert revert
cd0af69 fix: fix font ligature issues
90ac930 chore: add typedSignatureEnabled field via API
4a051f0 chore: make typedSignatureEnabled true by default
19dd633 Merge branch 'main' into feat/typed-signature-updates
c30bbb8 chore: add typed signature setting to team preferences
29f062b Merge branch 'main' into feat/typed-signature-updates
3dc5012 chore: use uselayouteffect and remove unnecessary stuff from the general page

📊 Changes

43 files changed (+1299 additions, -1365 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/templates/[id]/edit/edit-template.tsx (+27 -4)
📝 apps/web/src/app/(dashboard)/templates/[id]/template-page-view.tsx (+1 -2)
📝 apps/web/src/app/(internal)/%5F%5Fhtmltopdf/certificate/page.tsx (+13 -5)
📝 apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx (+3 -3)
📝 apps/web/src/app/(signing)/sign/[token]/provider.tsx (+7 -1)
📝 apps/web/src/app/(signing)/sign/[token]/signature-field.tsx (+63 -6)
📝 apps/web/src/app/(teams)/t/[teamUrl]/settings/page.tsx (+1 -7)
📝 apps/web/src/app/(teams)/t/[teamUrl]/settings/preferences/document-preferences.tsx (+35 -1)
📝 apps/web/src/app/embed/completed.tsx (+1 -0)
📝 apps/web/src/app/embed/direct/[[...url]]/client.tsx (+6 -6)
📝 apps/web/src/app/embed/document-fields.tsx (+1 -0)
📝 apps/web/src/app/embed/sign/[[...url]]/client.tsx (+3 -3)
📝 apps/web/src/components/(teams)/forms/update-team-form.tsx (+2 -105)
📝 apps/web/src/components/forms/profile.tsx (+1 -0)
📝 package-lock.json (+35 -332)
📝 packages/api/v1/implementation.ts (+1 -0)
📝 packages/api/v1/schema.ts (+9 -6)
📝 packages/app-tests/e2e/teams/team-global-settings.spec.ts (+8 -13)
📝 packages/lib/jobs/definitions/emails/send-team-deleted-email.ts (+1 -0)
📝 packages/lib/server-only/document/create-document.ts (+1 -0)

...and 23 more files

📄 Description

Enable typed signature by default and also add the option to set a typed signature in the profile page.

Summary by CodeRabbit

Release Notes

New Features
- Introduced the ability to input typed signatures alongside drawn signatures in the Profile Form.
- Added a global setting for enabling or disabling typed signatures for teams.
- Enhanced error handling for typed signatures based on team settings.
- Improved form functionality to manage typed signatures in document preferences.
- Added new mutation for updating typed signature settings in templates.
- Enhanced template editing process to manage typed signature settings alongside other fields.
- Updated the handling of signatures in various components to ensure correct processing based on input format.
Bug Fixes
- Improved rendering logic for displaying signatures, ensuring typed signatures are displayed correctly.
Documentation
- Updated localization files to include new translations related to typed signatures and document actions.
Chores
- Streamlined the Update Team Form by removing unnecessary properties, simplifying user interactions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1436 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/26/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/typed-signature-updates` --- ### 📝 Commits (10+) - [`b7bb303`](https://github.com/documenso/documenso/commit/b7bb303c0dbf84b216402c3e5178ea65a1b9b309) fix: enable typed signatures by default - [`e3be2ed`](https://github.com/documenso/documenso/commit/e3be2ed25b71e488ca7ad3f6b56b563e90233730) Revert "fix: enable typed signatures by default" - [`0d6987e`](https://github.com/documenso/documenso/commit/0d6987ee111fd5679146194532c755f59f32796e) fix: revert revert - [`cd0af69`](https://github.com/documenso/documenso/commit/cd0af698ea6e056c24affcc379edc855a93880ed) fix: fix font ligature issues - [`90ac930`](https://github.com/documenso/documenso/commit/90ac930e93357446a1a4bc9b49fb8ad30e958297) chore: add typedSignatureEnabled field via API - [`4a051f0`](https://github.com/documenso/documenso/commit/4a051f071b833e33f3c636bad071aca1b058a108) chore: make typedSignatureEnabled true by default - [`19dd633`](https://github.com/documenso/documenso/commit/19dd633c18411c535a99c8574a47fa978b92f952) Merge branch 'main' into feat/typed-signature-updates - [`c30bbb8`](https://github.com/documenso/documenso/commit/c30bbb83dac92ef1ef53b1e49011d390dcc7d1b9) chore: add typed signature setting to team preferences - [`29f062b`](https://github.com/documenso/documenso/commit/29f062bc9f283db6b6e1a2c828159e9e47ffe936) Merge branch 'main' into feat/typed-signature-updates - [`3dc5012`](https://github.com/documenso/documenso/commit/3dc50123d2fdc5b64a98235e9bd865ce49c37e24) chore: use uselayouteffect and remove unnecessary stuff from the general page ### 📊 Changes **43 files changed** (+1299 additions, -1365 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/templates/[id]/edit/edit-template.tsx` (+27 -4) 📝 `apps/web/src/app/(dashboard)/templates/[id]/template-page-view.tsx` (+1 -2) 📝 `apps/web/src/app/(internal)/%5F%5Fhtmltopdf/certificate/page.tsx` (+13 -5) 📝 `apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx` (+3 -3) 📝 `apps/web/src/app/(signing)/sign/[token]/provider.tsx` (+7 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/signature-field.tsx` (+63 -6) 📝 `apps/web/src/app/(teams)/t/[teamUrl]/settings/page.tsx` (+1 -7) 📝 `apps/web/src/app/(teams)/t/[teamUrl]/settings/preferences/document-preferences.tsx` (+35 -1) 📝 `apps/web/src/app/embed/completed.tsx` (+1 -0) 📝 `apps/web/src/app/embed/direct/[[...url]]/client.tsx` (+6 -6) 📝 `apps/web/src/app/embed/document-fields.tsx` (+1 -0) 📝 `apps/web/src/app/embed/sign/[[...url]]/client.tsx` (+3 -3) 📝 `apps/web/src/components/(teams)/forms/update-team-form.tsx` (+2 -105) 📝 `apps/web/src/components/forms/profile.tsx` (+1 -0) 📝 `package-lock.json` (+35 -332) 📝 `packages/api/v1/implementation.ts` (+1 -0) 📝 `packages/api/v1/schema.ts` (+9 -6) 📝 `packages/app-tests/e2e/teams/team-global-settings.spec.ts` (+8 -13) 📝 `packages/lib/jobs/definitions/emails/send-team-deleted-email.ts` (+1 -0) 📝 `packages/lib/server-only/document/create-document.ts` (+1 -0) _...and 23 more files_ </details> ### 📄 Description Enable typed signature by default and also add the option to set a typed signature in the profile page.  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced the ability to input typed signatures alongside drawn signatures in the Profile Form. - Added a global setting for enabling or disabling typed signatures for teams. - Enhanced error handling for typed signatures based on team settings. - Improved form functionality to manage typed signatures in document preferences. - Added new mutation for updating typed signature settings in templates. - Enhanced template editing process to manage typed signature settings alongside other fields. - Updated the handling of signatures in various components to ensure correct processing based on input format. - **Bug Fixes** - Improved rendering logic for displaying signatures, ensuring typed signatures are displayed correctly. - **Documentation** - Updated localization files to include new translations related to typed signatures and document actions. - **Chores** - Streamlined the Update Team Form by removing unnecessary properties, simplifying user interactions.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:04 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1628

No description provided.

Rows
Columns