[PR #1424] [MERGED] fix: missing not found page for deleted documents #1621

New issue

Closed

opened 2026-02-26 19:34:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1424
Author: @dguyen
Created: 10/28/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @dguyen

Base: main ← Head: fix/missing-document-not-found-page

📝 Commits (1)

9e43c92 fix: missing 404 for deleted documents

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+6 -6)

📄 Description

Description

Resolves #1387

Currently getIsRecipientsTurnToSign throws an error when a document is not found, which causes an unfriendly error on the front-end.

This commit pushes the check to occur after the notFound check is run.

Summary by CodeRabbit

New Features
- Enhanced logic for determining if it is the recipient's turn to sign, improving the sequence of operations on the signing page.
Bug Fixes
- Retained error handling for unauthorized signing, ensuring users are redirected appropriately.
Refactor
- Adjusted control flow to prioritize data retrieval before evaluating signing status.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1424 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/missing-document-not-found-page` --- ### 📝 Commits (1) - [`9e43c92`](https://github.com/documenso/documenso/commit/9e43c9217e336af8b97dd2b05da62089c40978ac) fix: missing 404 for deleted documents ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+6 -6) </details> ### 📄 Description ## Description Resolves #1387 Currently `getIsRecipientsTurnToSign` throws an error when a document is not found, which causes an unfriendly error on the front-end. This commit pushes the check to occur after the `notFound` check is run.  ## Summary by CodeRabbit - **New Features** - Enhanced logic for determining if it is the recipient's turn to sign, improving the sequence of operations on the signing page. - **Bug Fixes** - Retained error handling for unauthorized signing, ensuring users are redirected appropriately. - **Refactor** - Adjusted control flow to prioritize data retrieval before evaluating signing status.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:02 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1621

No description provided.

Rows
Columns