[PR #1412] [MERGED] fix: close direct link dialog when you click on save #1615

Closed
opened 2026-02-26 19:34:00 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1412
Author: @ephraimduncan
Created: 10/18/2024
Status: Merged
Merged: 10/21/2024
Merged by: @Mythie

Base: mainHead: fix/direct-link-dialog


📝 Commits (4)

  • 08b8085 fix: close direct link dialog when you click on save
  • 291d481 fix: eslint build error
  • 2f9a9dc fix: eslint build error
  • d270ab9 chore: update test

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx (+6 -4)
📝 packages/app-tests/e2e/templates/direct-templates.spec.ts (+0 -1)

📄 Description

Summary by CodeRabbit

  • New Features

    • Enhanced the save functionality in the Template Direct Link dialog for improved user experience.
    • Added new test cases for direct template link functionality, including creation, toggling, deletion, and authentication checks.
  • Bug Fixes

    • Improved error handling during the toggle operation to prevent unhandled errors.
    • Expanded tests to ensure proper visibility of error messages when templates are not found.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1412 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 10/18/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/direct-link-dialog` --- ### 📝 Commits (4) - [`08b8085`](https://github.com/documenso/documenso/commit/08b8085d2ac7c0aca2768faa59b770a7182f5205) fix: close direct link dialog when you click on save - [`291d481`](https://github.com/documenso/documenso/commit/291d4818bd0a4cad416d2c946cce7f7995fc7e80) fix: eslint build error - [`2f9a9dc`](https://github.com/documenso/documenso/commit/2f9a9dcac06c5ad0c605cbe886f2fce8ed362f8d) fix: eslint build error - [`d270ab9`](https://github.com/documenso/documenso/commit/d270ab9b5e8d68598d7dccd859c7e1e022bf6957) chore: update test ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx` (+6 -4) 📝 `packages/app-tests/e2e/templates/direct-templates.spec.ts` (+0 -1) </details> ### 📄 Description <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the save functionality in the Template Direct Link dialog for improved user experience. - Added new test cases for direct template link functionality, including creation, toggling, deletion, and authentication checks. - **Bug Fixes** - Improved error handling during the toggle operation to prevent unhandled errors. - Expanded tests to ensure proper visibility of error messages when templates are not found. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:34:00 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1615
No description provided.