[PR #1407] [CLOSED] feat: self sign #1613

New issue

Closed

opened 2026-02-26 19:34:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1407
Author: @ephraimduncan
Created: 10/17/2024
Status: ❌ Closed

Base: archive/nextjs ← Head: experiment/self-sign

📝 Commits (10+)

f9e3993 feat: avoid sending document if the owner is the only recipient
b55c419 chore: minor changes
cc8b972 fix: recipient status stuck on uncompleted
bb805ea fix: audit logs
2a098f8 chore: add tests for self signing
4348a94 chore: changes based on review
63c9894 chore: merge main
21d68f3 fix: merge conflicts
634dc2a fix: self sign team documents
1aee1bb Merge branch 'main' into experiment/self-sign

📊 Changes

11 files changed (+380 additions, -26 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx (+29 -3)
📝 apps/web/src/components/document/document-history-sheet.tsx (+10 -0)
📝 package-lock.json (+15 -0)
📝 packages/app-tests/e2e/document-flow/stepper-component.spec.ts (+94 -12)
➕ packages/lib/server-only/document/self-sign-document.ts (+177 -0)
📝 packages/lib/server-only/document/send-document.tsx (+1 -1)
📝 packages/lib/types/document-audit-logs.ts (+10 -0)
📝 packages/lib/utils/document-audit-logs.ts (+8 -10)
📝 packages/trpc/server/document-router/router.ts (+24 -0)
📝 packages/trpc/server/document-router/schema.ts (+5 -0)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+7 -0)

📄 Description

https://github.com/user-attachments/assets/230f923d-f72a-49f7-92a2-c3dfb22ef0e3

Summary by CodeRabbit

Release Notes

New Features
- Introduced self-signing functionality for documents, allowing users to sign their documents directly if they are the intended recipient.
- Enhanced document history tracking to include entries for self-sign actions, displaying the signer's email.
- Updated user interface elements to reflect ownership checks for document signing.
- Added session management to improve user experience during document signing.
- New translation entries for document rejection and self-signing notifications added for German, English, Spanish, and French.
Bug Fixes
- Improved error handling for document sending and signing processes to prevent runtime errors.
Localization
- Updated translations for German, English, Spanish, and French, enhancing clarity and accuracy across various user interface strings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1407 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 10/17/2024 **Status:** ❌ Closed **Base:** `archive/nextjs` ← **Head:** `experiment/self-sign` --- ### 📝 Commits (10+) - [`f9e3993`](https://github.com/documenso/documenso/commit/f9e39935194be24f1178eb941e3b29b5a60e4c42) feat: avoid sending document if the owner is the only recipient - [`b55c419`](https://github.com/documenso/documenso/commit/b55c419074bed1a671092e75a3384b12a009c626) chore: minor changes - [`cc8b972`](https://github.com/documenso/documenso/commit/cc8b972fbc785b66bf4a383320f84672d75fa6fe) fix: recipient status stuck on uncompleted - [`bb805ea`](https://github.com/documenso/documenso/commit/bb805ea93bd7bd751fa90a1eede7e9483b91d8a6) fix: audit logs - [`2a098f8`](https://github.com/documenso/documenso/commit/2a098f89fad4d8921db651337821afcc1b2b4902) chore: add tests for self signing - [`4348a94`](https://github.com/documenso/documenso/commit/4348a949ddeb7cf08d2160342dd02ceb9e1332ca) chore: changes based on review - [`63c9894`](https://github.com/documenso/documenso/commit/63c98949bb1006eb68535b5a8940ce0abfc11b4d) chore: merge main - [`21d68f3`](https://github.com/documenso/documenso/commit/21d68f327562de398265b6fec8a3e1f848058dc2) fix: merge conflicts - [`634dc2a`](https://github.com/documenso/documenso/commit/634dc2afd02d5748a85557545500eb19655b7bf8) fix: self sign team documents - [`1aee1bb`](https://github.com/documenso/documenso/commit/1aee1bb4cd00f91a8e69d5015d5cef250d2c98f4) Merge branch 'main' into experiment/self-sign ### 📊 Changes **11 files changed** (+380 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx` (+29 -3) 📝 `apps/web/src/components/document/document-history-sheet.tsx` (+10 -0) 📝 `package-lock.json` (+15 -0) 📝 `packages/app-tests/e2e/document-flow/stepper-component.spec.ts` (+94 -12) ➕ `packages/lib/server-only/document/self-sign-document.ts` (+177 -0) 📝 `packages/lib/server-only/document/send-document.tsx` (+1 -1) 📝 `packages/lib/types/document-audit-logs.ts` (+10 -0) 📝 `packages/lib/utils/document-audit-logs.ts` (+8 -10) 📝 `packages/trpc/server/document-router/router.ts` (+24 -0) 📝 `packages/trpc/server/document-router/schema.ts` (+5 -0) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+7 -0) </details> ### 📄 Description https://github.com/user-attachments/assets/230f923d-f72a-49f7-92a2-c3dfb22ef0e3  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced self-signing functionality for documents, allowing users to sign their documents directly if they are the intended recipient. - Enhanced document history tracking to include entries for self-sign actions, displaying the signer's email. - Updated user interface elements to reflect ownership checks for document signing. - Added session management to improve user experience during document signing. - New translation entries for document rejection and self-signing notifications added for German, English, Spanish, and French. - **Bug Fixes** - Improved error handling for document sending and signing processes to prevent runtime errors. - **Localization** - Updated translations for German, English, Spanish, and French, enhancing clarity and accuracy across various user interface strings.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:00 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1613

No description provided.

Rows
Columns