[PR #1368] [CLOSED] fix: console logging incorrect variable names #1590

Closed
opened 2026-02-26 19:33:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1368
Author: @jtmaveryk
Created: 9/28/2024
Status: Closed

Base: mainHead: main


📝 Commits (1)

  • e1fb44e Fix: console logging incorrect variable names

📊 Changes

1 file changed (+7 additions, -13 deletions)

View changed files

📝 packages/lib/constants/crypto.ts (+7 -13)

📄 Description

If you're missing either of the variables, it'll say you're missing the variable variant including DOCUMENSO instead of NEXT_PRIVATE, which can be misleading while debugging.


name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Changes Made

  • Change 1
  • Change 2
  • ...

Testing Performed

  • Tested feature X in scenario Y.
  • Ran unit tests for component Z.
  • Tested on browsers A, B, and C.
  • ...

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Summary by CodeRabbit

  • New Features

    • Updated encryption key constants for improved clarity and consistency.
  • Bug Fixes

    • Enhanced error messages to reflect the new constant names for better user understanding.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1368 **Author:** [@jtmaveryk](https://github.com/jtmaveryk) **Created:** 9/28/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`e1fb44e`](https://github.com/documenso/documenso/commit/e1fb44e259a0e6c536827cb6f523bcf9053cb182) Fix: console logging incorrect variable names ### 📊 Changes **1 file changed** (+7 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/constants/crypto.ts` (+7 -13) </details> ### 📄 Description If you're missing either of the variables, it'll say you're missing the variable variant including `DOCUMENSO` instead of `NEXT_PRIVATE`, which can be misleading while debugging. --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description <!--- Describe the changes introduced by this pull request. --> <!--- Explain what problem it solves or what feature/fix it adds. --> ## Related Issue <!--- If this pull request is related to a specific issue, reference it here using #issue_number. --> <!--- For example, "Fixes #123" or "Addresses #456". --> ## Changes Made <!--- Provide a summary of the changes made in this pull request. --> <!--- Include any relevant technical details or architecture changes. --> - Change 1 - Change 2 - ... ## Testing Performed <!--- Describe the testing that you have performed to validate these changes. --> <!--- Include information about test cases, testing environments, and results. --> - Tested feature X in scenario Y. - Ran unit tests for component Z. - Tested on browsers A, B, and C. - ... ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <!--- Provide any additional context or notes for the reviewers. --> <!--- This might include details about design decisions, potential concerns, or anything else relevant. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated encryption key constants for improved clarity and consistency. - **Bug Fixes** - Enhanced error messages to reflect the new constant names for better user understanding. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1590
No description provided.