[PR #1365] [MERGED] fix: set lang cookie expiry #1589

Closed
opened 2026-02-26 19:33:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1365
Author: @dguyen
Created: 9/25/2024
Status: Merged
Merged: 9/25/2024
Merged by: @dguyen

Base: mainHead: fix/lang-cookie-expiry


📝 Commits (1)

  • abedddb fix: set lang cookie expiry

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 packages/lib/server-only/i18n/switch-i18n-language.ts (+4 -1)

📄 Description

Description

Currently the language cookie is set to session, so restarting browser will reset it.

This sets the expiry for two years.

Summary by CodeRabbit

  • New Features

    • Enhanced language preference functionality with extended cookie lifespan for improved user experience.
  • Bug Fixes

    • Resolved issues related to cookie expiration for language settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1365 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/lang-cookie-expiry` --- ### 📝 Commits (1) - [`abedddb`](https://github.com/documenso/documenso/commit/abedddbf0faf8320040a1f5c0b1b350112d782b7) fix: set lang cookie expiry ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/i18n/switch-i18n-language.ts` (+4 -1) </details> ### 📄 Description ## Description Currently the language cookie is set to session, so restarting browser will reset it. This sets the expiry for two years. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced language preference functionality with extended cookie lifespan for improved user experience. - **Bug Fixes** - Resolved issues related to cookie expiration for language settings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1589
No description provided.