[PR #1362] [MERGED] fix: external id null for documents created from templates #1587

New issue

Closed

opened 2026-02-26 19:33:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1362
Author: @ephraimduncan
Created: 9/23/2024
Status: ✅ Merged
Merged: 10/8/2024
Merged by: @Mythie

Base: main ← Head: fix/template-externalid

📝 Commits (3)

a832ab2 fix: external id null for templates
b1a9a84 fix: date format on documents
a09cea2 fix: api breaking

📊 Changes

4 files changed (+10 additions, -7 deletions)

View changed files

📝 packages/lib/server-only/template/create-document-from-template.ts (+6 -3)
📝 packages/lib/server-only/template/update-template-settings.ts (+1 -1)
📝 packages/trpc/server/template-router/router.ts (+2 -2)
📝 packages/ui/primitives/document-flow/add-settings.tsx (+1 -1)

📄 Description

Fix #1282

Summary by CodeRabbit

New Features
- Enhanced document creation by improving default handling for externalId and signingOrder.
- Added a recipients property to mutation input in the template router for improved functionality.
Bug Fixes
- Updated logic in updateTemplateSettings to correctly handle externalId assignment without defaulting to null.
- Modified date format selection logic in AddSettingsFormPartial for better accuracy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1362 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/template-externalid` --- ### 📝 Commits (3) - [`a832ab2`](https://github.com/documenso/documenso/commit/a832ab2fe35e417eb0f46504f829c4af711a0f05) fix: external id null for templates - [`b1a9a84`](https://github.com/documenso/documenso/commit/b1a9a84618049edfe21c548730d0a54dbf6c2b69) fix: date format on documents - [`a09cea2`](https://github.com/documenso/documenso/commit/a09cea2f7e3229f2280f1faf8d867e607018d917) fix: api breaking ### 📊 Changes **4 files changed** (+10 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/template/create-document-from-template.ts` (+6 -3) 📝 `packages/lib/server-only/template/update-template-settings.ts` (+1 -1) 📝 `packages/trpc/server/template-router/router.ts` (+2 -2) 📝 `packages/ui/primitives/document-flow/add-settings.tsx` (+1 -1) </details> ### 📄 Description Fix #1282  ## Summary by CodeRabbit - **New Features** - Enhanced document creation by improving default handling for `externalId` and `signingOrder`. - Added a `recipients` property to mutation input in the template router for improved functionality. - **Bug Fixes** - Updated logic in `updateTemplateSettings` to correctly handle `externalId` assignment without defaulting to `null`. - Modified date format selection logic in `AddSettingsFormPartial` for better accuracy.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1587

No description provided.

Rows
Columns