[PR #1364] [MERGED] fix: carousel slide change handling and video reset #1586

New issue

Closed

opened 2026-02-26 19:33:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1364
Author: @ephraimduncan
Created: 9/23/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @Mythie

Base: main ← Head: fix/reset-video-on-tab-click

📝 Commits (1)

a7781c3 refactor(carousel): improve slide change handling and video reset

📊 Changes

4 files changed (+13 additions, -6 deletions)

View changed files

📝 apps/marketing/src/components/(marketing)/carousel.tsx (+10 -3)
📝 packages/lib/translations/de/marketing.po (+1 -1)
📝 packages/lib/translations/en/marketing.po (+1 -1)
📝 packages/lib/translations/fr/marketing.po (+1 -1)

📄 Description

https://github.com/user-attachments/assets/dfc524b2-f1a7-4564-9f52-605ec1d619ef

Summary by CodeRabbit

New Features
- Enhanced video playback in the Carousel component, ensuring videos start from the beginning when selected.
Bug Fixes
- Updated handling for the "Your browser does not support the video tag" message across multiple languages.
Translations
- Improved clarity and consistency in French translations related to self-hosting options.
- Minor adjustments made to German translations for better accuracy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1364 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/reset-video-on-tab-click` --- ### 📝 Commits (1) - [`a7781c3`](https://github.com/documenso/documenso/commit/a7781c302a81da1bd764c01ef76043c1ba628c43) refactor(carousel): improve slide change handling and video reset ### 📊 Changes **4 files changed** (+13 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/src/components/(marketing)/carousel.tsx` (+10 -3) 📝 `packages/lib/translations/de/marketing.po` (+1 -1) 📝 `packages/lib/translations/en/marketing.po` (+1 -1) 📝 `packages/lib/translations/fr/marketing.po` (+1 -1) </details> ### 📄 Description https://github.com/user-attachments/assets/dfc524b2-f1a7-4564-9f52-605ec1d619ef  ## Summary by CodeRabbit - **New Features** - Enhanced video playback in the Carousel component, ensuring videos start from the beginning when selected. - **Bug Fixes** - Updated handling for the "Your browser does not support the video tag" message across multiple languages. - **Translations** - Improved clarity and consistency in French translations related to self-hosting options. - Minor adjustments made to German translations for better accuracy.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1586

No description provided.

Rows
Columns