[PR #1361] [MERGED] fix: stacked avatar colors #1585

Closed
opened 2026-02-26 19:33:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1361
Author: @ephraimduncan
Created: 9/23/2024
Status: Merged
Merged: 10/9/2024
Merged by: @Mythie

Base: mainHead: fix/stack-avatars


📝 Commits (2)

📊 Changes

6 files changed (+74 additions, -32 deletions)

View changed files

📝 apps/web/src/components/(dashboard)/avatar/stack-avatars-with-tooltip.tsx (+11 -7)
📝 apps/web/src/components/(dashboard)/avatar/stack-avatars.tsx (+18 -8)
📝 packages/lib/client-only/recipient-type.ts (+33 -5)
📝 packages/lib/translations/de/web.po (+4 -4)
📝 packages/lib/translations/en/web.po (+4 -4)
📝 packages/lib/translations/fr/web.po (+4 -4)

📄 Description

Before

CleanShot 2024-09-21 at 13 46 17@2x

After

CleanShot 2024-09-21 at 12 32 30@2x

Summary by CodeRabbit

  • New Features
    • Introduced sorting for recipient avatars by ID for improved organization.
    • Added functionality to determine the type of additional recipients when rendering avatars.
  • Bug Fixes
    • Enhanced logic for rendering avatars to better handle extra recipients and their statuses.
  • Refactor
    • Simplified rendering logic for the first four recipient avatars.
    • Updated recipient type checks to use enumerated types for better clarity and maintainability.
  • Translations
    • Updated line references for translation strings in German, English, and French without altering the content.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1361 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/stack-avatars` --- ### 📝 Commits (2) - [`212ce5d`](https://github.com/documenso/documenso/commit/212ce5da2d6df95cda593df1f6c65643f5c5f4ff) fix: stacked avatar colors - [`4c22fae`](https://github.com/documenso/documenso/commit/4c22fae563460c2f10b819c6dff4479855da4550) chore: code review ### 📊 Changes **6 files changed** (+74 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/components/(dashboard)/avatar/stack-avatars-with-tooltip.tsx` (+11 -7) 📝 `apps/web/src/components/(dashboard)/avatar/stack-avatars.tsx` (+18 -8) 📝 `packages/lib/client-only/recipient-type.ts` (+33 -5) 📝 `packages/lib/translations/de/web.po` (+4 -4) 📝 `packages/lib/translations/en/web.po` (+4 -4) 📝 `packages/lib/translations/fr/web.po` (+4 -4) </details> ### 📄 Description ### Before <img src="https://github.com/user-attachments/assets/86489074-df88-4b35-bd69-1b66281b7972" alt="CleanShot 2024-09-21 at 13 46 17@2x" width="300"> ### After <img src="https://github.com/user-attachments/assets/869bbab1-b56c-40a3-a89d-a22d478d2f30" alt="CleanShot 2024-09-21 at 12 32 30@2x" width="300"> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced sorting for recipient avatars by ID for improved organization. - Added functionality to determine the type of additional recipients when rendering avatars. - **Bug Fixes** - Enhanced logic for rendering avatars to better handle extra recipients and their statuses. - **Refactor** - Simplified rendering logic for the first four recipient avatars. - Updated recipient type checks to use enumerated types for better clarity and maintainability. - **Translations** - Updated line references for translation strings in German, English, and French without altering the content. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1585
No description provided.