starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #1348] [MERGED] fix: fix `passkeys` page-breaking error #1573

New issue

Closed

opened 2026-02-26 19:33:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1348
Author: @apsinghdev
Created: 9/16/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @Mythie

Base: main ← Head: fix/manage-passkeys

📝 Commits (1)

1895338 fix(passkey): correct msg usage to avoid page-breaking error

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/settings/security/passkeys/user-passkeys-data-table.tsx (+1 -1)

📄 Description

Description

This PR fixes the bug that was breaking the Passkeys page.

fixes: #1347

Changes Made

Changed msg `Never` to `_(msg`Never`)` So that columns don't take it as an object (that can't be passed directly to a react component.)

Testing Performed

Here is how this change fixed the problem :

https://github.com/user-attachments/assets/cbbbade7-608a-49da-9273-cf657d0ae8ae

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Summary by CodeRabbit

New Features
- Enhanced internationalization support for the "Never" message in the User Passkeys Data Table, improving localization based on user preferences.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1348 **Author:** [@apsinghdev](https://github.com/apsinghdev) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/manage-passkeys` --- ### 📝 Commits (1) - [`1895338`](https://github.com/documenso/documenso/commit/1895338d5bc05a3181eee3f9478e591500e13037) fix(passkey): correct msg usage to avoid page-breaking error ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/settings/security/passkeys/user-passkeys-data-table.tsx` (+1 -1) </details> ### 📄 Description ## Description  This PR fixes the bug that was breaking the `Passkeys` page.  ## Related Issue fixes: #1347   ## Changes Made Changed `` msg `Never` `` to `` `_(msg`Never`)` `` So that `columns` don't take it as an object (that can't be passed directly to a react component.) ## Testing Performed Here is how this change fixed the problem : https://github.com/user-attachments/assets/cbbbade7-608a-49da-9273-cf657d0ae8ae ## Checklist   - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes    ## Summary by CodeRabbit - **New Features** - Enhanced internationalization support for the "Never" message in the User Passkeys Data Table, improving localization based on user preferences.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:50 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1573

No description provided.

Rows
Columns

[PR #1348] [MERGED] fix: fix passkeys page-breaking error #1573