[PR #1346] [MERGED] feat: allow editing pending documents #1572

Closed
opened 2026-02-26 19:33:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1346
Author: @dguyen
Created: 9/13/2024
Status: Merged
Merged: 9/20/2024
Merged by: @dguyen

Base: mainHead: feat/document-pending-edit


📝 Commits (3)

  • f5e07af feat: allow editing pending documents
  • b62dfdc fix: use remeda instead of lodash
  • 127f714 Merge branch 'main' into feat/document-pending-edit

📊 Changes

21 files changed (+534 additions, -205 deletions)

View changed files

📝 apps/marketing/package.json (+2 -2)
📝 apps/web/package.json (+3 -3)
📝 package-lock.json (+75 -23)
📝 packages/ee/server-only/limits/provider/client.tsx (+2 -2)
packages/email/templates/recipient-removed-from-document.tsx (+78 -0)
📝 packages/lib/package.json (+1 -1)
📝 packages/lib/server-only/field/set-fields-for-document.ts (+69 -26)
📝 packages/lib/server-only/recipient/set-recipients-for-document.ts (+87 -25)
📝 packages/lib/translations/de/common.po (+38 -26)
📝 packages/lib/translations/de/marketing.js (+1 -1)
📝 packages/lib/translations/de/web.js (+1 -1)
📝 packages/lib/translations/en/common.po (+39 -27)
📝 packages/lib/translations/en/marketing.js (+1 -1)
📝 packages/lib/translations/en/web.js (+1 -1)
📝 packages/lib/translations/fr/common.po (+34 -26)
📝 packages/lib/translations/fr/marketing.js (+1 -1)
📝 packages/lib/translations/fr/web.js (+1 -1)
packages/lib/utils/recipients.ts (+33 -0)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+27 -8)
📝 packages/ui/primitives/document-flow/add-signers.tsx (+39 -30)

...and 1 more files

📄 Description

Description

Adds the ability for the document owner to edit recipients and their fields after the document has been sent.

A recipient can only be updated or deleted if:

  • The recipient has not inserted any fields
  • Has not completed the document

Summary by CodeRabbit

Release Notes

  • New Features

    • Added new localization messages to clarify user actions regarding document signing.
    • Enhanced French translations for improved user interaction.
  • Improvements

    • Updated localization strings in German and English for clearer feedback on signer and recipient statuses.
    • Improved overall structure of localization files for better maintainability.
  • Dependency Updates

    • Upgraded next-axiom and remeda libraries to their latest versions, potentially enhancing performance and stability.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1346 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/20/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `feat/document-pending-edit` --- ### 📝 Commits (3) - [`f5e07af`](https://github.com/documenso/documenso/commit/f5e07af3b9cfe5a2444c6e988729a93645bafb06) feat: allow editing pending documents - [`b62dfdc`](https://github.com/documenso/documenso/commit/b62dfdc8dc7260d64bde2c572060e601ece5d9d6) fix: use remeda instead of lodash - [`127f714`](https://github.com/documenso/documenso/commit/127f71434c7425d4f898f67648bae9dc79fa24e5) Merge branch 'main' into feat/document-pending-edit ### 📊 Changes **21 files changed** (+534 additions, -205 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/package.json` (+2 -2) 📝 `apps/web/package.json` (+3 -3) 📝 `package-lock.json` (+75 -23) 📝 `packages/ee/server-only/limits/provider/client.tsx` (+2 -2) ➕ `packages/email/templates/recipient-removed-from-document.tsx` (+78 -0) 📝 `packages/lib/package.json` (+1 -1) 📝 `packages/lib/server-only/field/set-fields-for-document.ts` (+69 -26) 📝 `packages/lib/server-only/recipient/set-recipients-for-document.ts` (+87 -25) 📝 `packages/lib/translations/de/common.po` (+38 -26) 📝 `packages/lib/translations/de/marketing.js` (+1 -1) 📝 `packages/lib/translations/de/web.js` (+1 -1) 📝 `packages/lib/translations/en/common.po` (+39 -27) 📝 `packages/lib/translations/en/marketing.js` (+1 -1) 📝 `packages/lib/translations/en/web.js` (+1 -1) 📝 `packages/lib/translations/fr/common.po` (+34 -26) 📝 `packages/lib/translations/fr/marketing.js` (+1 -1) 📝 `packages/lib/translations/fr/web.js` (+1 -1) ➕ `packages/lib/utils/recipients.ts` (+33 -0) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+27 -8) 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+39 -30) _...and 1 more files_ </details> ### 📄 Description ## Description Adds the ability for the document owner to edit recipients and their fields after the document has been sent. A recipient can only be updated or deleted if: - The recipient has not inserted any fields - Has not completed the document <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Added new localization messages to clarify user actions regarding document signing. - Enhanced French translations for improved user interaction. - **Improvements** - Updated localization strings in German and English for clearer feedback on signer and recipient statuses. - Improved overall structure of localization files for better maintainability. - **Dependency Updates** - Upgraded `next-axiom` and `remeda` libraries to their latest versions, potentially enhancing performance and stability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1572
No description provided.