starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1344] [MERGED] feat: support smaller field bounds #1571

New issue

Closed

opened 2026-02-26 19:33:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1344
Author: @Mythie
Created: 9/11/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @Mythie

Base: main ← Head: feat/let-fields-be-smaller

📝 Commits (1)

ceed4dc feat: support smaller field bounds

📊 Changes

20 files changed (+75 additions, -49 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx (+3 -3)
📝 apps/web/src/app/(signing)/sign/[token]/date-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx (+5 -2)
📝 apps/web/src/app/(signing)/sign/[token]/email-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/initials-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/name-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/number-field.tsx (+2 -2)
📝 apps/web/src/app/(signing)/sign/[token]/radio-field.tsx (+3 -3)
📝 apps/web/src/app/(signing)/sign/[token]/signing-field-container.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/text-field.tsx (+2 -2)
📝 packages/lib/translations/de/web.js (+1 -1)
📝 packages/lib/translations/de/web.po (+16 -7)
📝 packages/lib/translations/en/web.js (+1 -1)
📝 packages/lib/translations/en/web.po (+16 -7)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+2 -2)
📝 packages/ui/primitives/document-flow/advanced-fields/checkbox.tsx (+5 -3)
📝 packages/ui/primitives/document-flow/advanced-fields/radio.tsx (+5 -3)
📝 packages/ui/primitives/document-flow/field-icon.tsx (+4 -4)
📝 packages/ui/primitives/document-flow/field-item.tsx (+3 -2)
📝 packages/ui/primitives/template-flow/add-template-fields.tsx (+2 -2)

📄 Description

Currently this won't always display super well since
our insertion solution isn't amazing but our current
minimum bounds within the UI are a bit large and can be
smaller.

This change makes it smaller and uses container queries to
support dynamically displaying labels based on the container
size.

N/A

Changes Made

Updated our MIN_FIELD_SIZE constants
Updated our field styling to support the smaller bounds

Testing Performed

Created and signed a series of documents to ensure we aren't allowing for sizes that would cause a drastic different from the web app to the final pdf.

Summary by CodeRabbit

New Features
- Enhanced styling for form components including checkboxes, radio buttons, and text fields for improved visual consistency and responsiveness.
- Updated localization strings for better clarity in user interface elements, replacing outdated terms with more concise labels.
Bug Fixes
- Improved responsiveness of text elements across various fields using dynamic sizing techniques.
Chores
- Adjusted minimum dimensions for UI components to optimize layout and rendering.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1344 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 9/11/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/let-fields-be-smaller` --- ### 📝 Commits (1) - [`ceed4dc`](https://github.com/documenso/documenso/commit/ceed4dcbb93c442b2f5ec7c63fe0e402cfdb60df) feat: support smaller field bounds ### 📊 Changes **20 files changed** (+75 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/checkbox-field.tsx` (+3 -3) 📝 `apps/web/src/app/(signing)/sign/[token]/date-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx` (+5 -2) 📝 `apps/web/src/app/(signing)/sign/[token]/email-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/initials-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/name-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/number-field.tsx` (+2 -2) 📝 `apps/web/src/app/(signing)/sign/[token]/radio-field.tsx` (+3 -3) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-field-container.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/text-field.tsx` (+2 -2) 📝 `packages/lib/translations/de/web.js` (+1 -1) 📝 `packages/lib/translations/de/web.po` (+16 -7) 📝 `packages/lib/translations/en/web.js` (+1 -1) 📝 `packages/lib/translations/en/web.po` (+16 -7) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+2 -2) 📝 `packages/ui/primitives/document-flow/advanced-fields/checkbox.tsx` (+5 -3) 📝 `packages/ui/primitives/document-flow/advanced-fields/radio.tsx` (+5 -3) 📝 `packages/ui/primitives/document-flow/field-icon.tsx` (+4 -4) 📝 `packages/ui/primitives/document-flow/field-item.tsx` (+3 -2) 📝 `packages/ui/primitives/template-flow/add-template-fields.tsx` (+2 -2) </details> ### 📄 Description Currently this won't always display super well since our insertion solution isn't amazing but our current minimum bounds within the UI are a bit large and can be smaller. This change makes it smaller and uses container queries to support dynamically displaying labels based on the container size. ## Related Issue N/A ## Changes Made - Updated our MIN_FIELD_SIZE constants - Updated our field styling to support the smaller bounds ## Testing Performed - Created and signed a series of documents to ensure we aren't allowing for sizes that would cause a drastic different from the web app to the final pdf.  ## Summary by CodeRabbit - **New Features** - Enhanced styling for form components including checkboxes, radio buttons, and text fields for improved visual consistency and responsiveness. - Updated localization strings for better clarity in user interface elements, replacing outdated terms with more concise labels. - **Bug Fixes** - Improved responsiveness of text elements across various fields using dynamic sizing techniques. - **Chores** - Adjusted minimum dimensions for UI components to optimize layout and rendering.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:47 +03:00

[PR #1571] [MERGED] feat: allow switching document when using templates #1724

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1571

No description provided.

Rows
Columns