[PR #1339] [MERGED] fix: template with empty advanced fields #1570

New issue

Closed

opened 2026-02-26 19:33:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1339
Author: @catalinpit
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @Mythie

Base: main ← Head: fix/template-advanced-fields-error

📝 Commits (1)

ff39d1b fix: template with empty advanced fields

📊 Changes

3 files changed (+81 additions, -28 deletions)

View changed files

📝 packages/lib/translations/de/common.po (+15 -14)
📝 packages/lib/translations/en/common.po (+15 -14)
📝 packages/ui/primitives/template-flow/add-template-fields.tsx (+51 -0)

📄 Description

Templates can be created and sent with advanced fields that have empty values. That will cause an error when the user tries to sign the document.

For example, you can create a template with a checkbox field and save it. Then, you can click the "Use template" button and send the document by clicking "Send document." However, this shouldn't be possible if the advanced field doesn't have any values.

https://github.com/user-attachments/assets/4ccfabf9-f3ef-49f9-8f24-5bbc35604587

The new changes mimic the logic of document creation. Users won't be able to save a template if it contains empty advanced fields.

Summary by CodeRabbit

New Features
- Enhanced form validation to prevent progression without addressing empty required fields.
- Added functionality to filter fields with empty values for CHECKBOX, RADIO, and DROPDOWN types.
- Introduced error messaging for users if required fields are not filled.
Bug Fixes
- Updated translation references to ensure accurate mapping of message strings following code changes.
Chores
- Systematic updates to translation files to maintain the integrity of the localization process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1339 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/template-advanced-fields-error` --- ### 📝 Commits (1) - [`ff39d1b`](https://github.com/documenso/documenso/commit/ff39d1b9c0f870e88e60958050fe7810a5927492) fix: template with empty advanced fields ### 📊 Changes **3 files changed** (+81 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/translations/de/common.po` (+15 -14) 📝 `packages/lib/translations/en/common.po` (+15 -14) 📝 `packages/ui/primitives/template-flow/add-template-fields.tsx` (+51 -0) </details> ### 📄 Description Templates can be created and sent with advanced fields that have empty values. That will cause an error when the user tries to sign the document. For example, you can create a template with a checkbox field and save it. Then, you can click the "Use template" button and send the document by clicking "Send document." However, this shouldn't be possible if the advanced field doesn't have any values. https://github.com/user-attachments/assets/4ccfabf9-f3ef-49f9-8f24-5bbc35604587 The new changes mimic the logic of document creation. Users won't be able to save a template if it contains empty advanced fields.  ## Summary by CodeRabbit - **New Features** - Enhanced form validation to prevent progression without addressing empty required fields. - Added functionality to filter fields with empty values for CHECKBOX, RADIO, and DROPDOWN types. - Introduced error messaging for users if required fields are not filled. - **Bug Fixes** - Updated translation references to ensure accurate mapping of message strings following code changes. - **Chores** - Systematic updates to translation files to maintain the integrity of the localization process.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:49 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1570

No description provided.

Rows
Columns