[PR #1334] [MERGED] fix: select field ux #1565

Closed
opened 2026-02-26 19:33:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1334
Author: @catalinpit
Created: 9/9/2024
Status: Merged
Merged: 9/10/2024
Merged by: @dguyen

Base: mainHead: fix/select-field-ux


📝 Commits (2)

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx (+3 -3)

📄 Description

When the Select field has a default value, it automatically signs with it. If you change it, you need to refresh the page to re-sign again with that value. This PR improves the UX by making the default value "selectable" in the dropdown menu.

Summary by CodeRabbit

  • New Features
    • Updated the DropdownField component to simplify the handling of default values, ensuring the dropdown starts without a pre-selected option.
    • Improved the clarity of the placeholder text in the dropdown, enhancing user experience.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1334 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/select-field-ux` --- ### 📝 Commits (2) - [`33317a1`](https://github.com/documenso/documenso/commit/33317a1b05826b0094141cc72d29d43e542bc010) fix: select field ux - [`7f55fed`](https://github.com/documenso/documenso/commit/7f55fed75d1a5bfa0a0e6884c87ea87b2809f544) fix: forgot this change ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx` (+3 -3) </details> ### 📄 Description When the Select field has a default value, it automatically signs with it. If you change it, you need to refresh the page to re-sign again with that value. This PR improves the UX by making the default value "selectable" in the dropdown menu. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the `DropdownField` component to simplify the handling of default values, ensuring the dropdown starts without a pre-selected option. - Improved the clarity of the placeholder text in the dropdown, enhancing user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1565
No description provided.