[PR #1330] [MERGED] feat: highlight problematic fields #1563

New issue

Closed

opened 2026-02-26 19:33:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1330
Author: @catalinpit
Created: 9/6/2024
Status: ✅ Merged
Merged: 10/8/2024
Merged by: @Mythie

Base: main ← Head: feat/highlight-problematic-fields

📝 Commits (10+)

1782279 feat: highlight problematic fields
be8dbae Merge branch 'main' into feat/highlight-problematic-fields
7a31a5f fix: wrong fields highlight
0a28037 feat: jump to problematic field
dae1abe chore: some temp fixes
c83e3e4 chore: add removed code
7b6b27d chore: rearrange code
122b15e chore: don't disable button
4de7447 chore: merge main
caeeab8 chore: remove conflict markers

📊 Changes

14 files changed (+158 additions, -68 deletions)

View changed files

📝 packages/lib/client-only/hooks/use-field-page-coords.ts (+1 -1)
📝 packages/lib/translations/de/common.po (+21 -17)
📝 packages/lib/translations/de/marketing.js (+1 -1)
📝 packages/lib/translations/de/web.js (+1 -1)
📝 packages/lib/translations/en/common.po (+21 -17)
📝 packages/lib/translations/en/marketing.js (+1 -1)
📝 packages/lib/translations/en/web.js (+1 -1)
📝 packages/lib/translations/fr/common.po (+21 -17)
📝 packages/lib/translations/fr/marketing.js (+1 -1)
📝 packages/lib/translations/fr/web.js (+1 -1)
📝 packages/lib/utils/fields.ts (+24 -0)
📝 packages/ui/components/field/field-tooltip.tsx (+1 -1)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+54 -7)
📝 packages/ui/primitives/document-flow/field-item.tsx (+9 -2)

📄 Description

https://github.com/user-attachments/assets/ac8830db-6ef9-4965-8679-44c7aef756aa

Summary by CodeRabbit

New Features
- Enhanced validation logic for uninserted fields in forms, improving error handling and user feedback.
- Updated tooltip display conditions for better contextual information.
- Introduced new translation entries in German, English, and French, enriching user engagement.
Bug Fixes
- Resolved merge conflicts in translation files that could affect user interface consistency.
Chores
- Optimized code imports for better performance and clarity.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1330 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 9/6/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/highlight-problematic-fields` --- ### 📝 Commits (10+) - [`1782279`](https://github.com/documenso/documenso/commit/1782279b8082b99de500680b25b3cc6340067fbf) feat: highlight problematic fields - [`be8dbae`](https://github.com/documenso/documenso/commit/be8dbae454fbeb1c4ff0395ac232ad120250059c) Merge branch 'main' into feat/highlight-problematic-fields - [`7a31a5f`](https://github.com/documenso/documenso/commit/7a31a5f493c07b56b8a1954d2c33248dd225e8cc) fix: wrong fields highlight - [`0a28037`](https://github.com/documenso/documenso/commit/0a280378209f6bf8835e69865903c8e82fe199db) feat: jump to problematic field - [`dae1abe`](https://github.com/documenso/documenso/commit/dae1abedf334926300a0e74359a527e9e9f06f19) chore: some temp fixes - [`c83e3e4`](https://github.com/documenso/documenso/commit/c83e3e4b0d86a8044963fd9521bfc61e4fd61f46) chore: add removed code - [`7b6b27d`](https://github.com/documenso/documenso/commit/7b6b27dbd65e473c69adf1bc0da5b730cfc1bd4d) chore: rearrange code - [`122b15e`](https://github.com/documenso/documenso/commit/122b15e0af46e81356d6e35f010d42b17d649bfc) chore: don't disable button - [`4de7447`](https://github.com/documenso/documenso/commit/4de7447a721281a67a544237dc273aa6943a06de) chore: merge main - [`caeeab8`](https://github.com/documenso/documenso/commit/caeeab8b128aaaee61199a1ca23b21bffee430b7) chore: remove conflict markers ### 📊 Changes **14 files changed** (+158 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/client-only/hooks/use-field-page-coords.ts` (+1 -1) 📝 `packages/lib/translations/de/common.po` (+21 -17) 📝 `packages/lib/translations/de/marketing.js` (+1 -1) 📝 `packages/lib/translations/de/web.js` (+1 -1) 📝 `packages/lib/translations/en/common.po` (+21 -17) 📝 `packages/lib/translations/en/marketing.js` (+1 -1) 📝 `packages/lib/translations/en/web.js` (+1 -1) 📝 `packages/lib/translations/fr/common.po` (+21 -17) 📝 `packages/lib/translations/fr/marketing.js` (+1 -1) 📝 `packages/lib/translations/fr/web.js` (+1 -1) 📝 `packages/lib/utils/fields.ts` (+24 -0) 📝 `packages/ui/components/field/field-tooltip.tsx` (+1 -1) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+54 -7) 📝 `packages/ui/primitives/document-flow/field-item.tsx` (+9 -2) </details> ### 📄 Description https://github.com/user-attachments/assets/ac8830db-6ef9-4965-8679-44c7aef756aa  ## Summary by CodeRabbit - **New Features** - Enhanced validation logic for uninserted fields in forms, improving error handling and user feedback. - Updated tooltip display conditions for better contextual information. - Introduced new translation entries in German, English, and French, enriching user engagement. - **Bug Fixes** - Resolved merge conflicts in translation files that could affect user interface consistency. - **Chores** - Optimized code imports for better performance and clarity.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:46 +03:00

[PR #1563] [MERGED] fix: merge common and web po files #1720

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1563

No description provided.

Rows
Columns