starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1324] [CLOSED] feat: select signature color #1560

New issue

Closed

opened 2026-02-26 19:33:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1324
Author: @catalinpit
Created: 9/5/2024
Status: ❌ Closed

Base: main ← Head: feat/signature-color

📝 Commits (5)

69bf404 feat: select signature color
a301dd3 feat: add colors
80d2d07 fix: select element width
51afe95 chore: merge main
a730acc chore: reverted merge

📊 Changes

68 files changed (+1064 additions, -2805 deletions)

View changed files

📝 .github/actions/cache-build/action.yml (+2 -2)
📝 .github/actions/node-install/action.yml (+1 -1)
📝 README.md (+0 -4)
📝 apps/documentation/package.json (+2 -2)
📝 apps/documentation/pages/developers/_meta.json (+1 -2)
➖ apps/documentation/pages/developers/embedding/index.mdx (+0 -131)
➖ apps/documentation/pages/developers/embedding/preact.mdx (+0 -77)
➖ apps/documentation/pages/developers/embedding/react.mdx (+0 -77)
➖ apps/documentation/pages/developers/embedding/solid.mdx (+0 -77)
➖ apps/documentation/pages/developers/embedding/svelte.mdx (+0 -79)
➖ apps/documentation/pages/developers/embedding/vue.mdx (+0 -79)
📝 apps/documentation/pages/developers/local-development/_meta.json (+2 -3)
➖ apps/documentation/pages/developers/local-development/translations.mdx (+0 -128)
📝 apps/documentation/pages/users/signing-documents/fields.mdx (+42 -42)
📝 apps/documentation/pages/users/signing-documents/index.mdx (+12 -12)
📝 apps/documentation/pages/users/templates.mdx (+8 -8)
➖ apps/documentation/public/embedding/copy-recipient-token.png (+0 -0)
➖ apps/documentation/public/embedding/enable-direct-link.png (+0 -0)
➖ apps/documentation/public/embedding/team-templates.png (+0 -0)
📝 apps/marketing/package.json (+17 -10)

...and 48 more files

📄 Description

Description

Allow users to select a colour for the signature. The allowed colours are black, white, red, blue, and green.

https://github.com/user-attachments/assets/82b97a16-45e2-4f5d-b938-27d27a59b558

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Introduced a color selection feature in the SignaturePad, allowing users to choose between black, red, blue, and green for their signatures.
- Added new translations for color names in both German and English localizations to enhance multilingual support.
Bug Fixes
- Updated existing translations for "Clear Signature" to reflect changes in line numbers for improved accuracy.
Documentation
- Enhanced localization documentation by expanding available translations for color options in the user interface.

Summary by CodeRabbit

New Features
- Introduced color selection for signatures in the SignaturePad component, allowing users to choose from five colors: black, white, red, blue, and green.
- Added new translations for color names in both German and English localizations, enhancing multilingual support.
Bug Fixes
- Updated existing translations for "Clear Signature" to reflect changes in line numbers.
Documentation
- Removed outdated deployment instructions for Elestio from the README.
- Updated image paths in various documentation files to ensure correct referencing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1324 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 9/5/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/signature-color` --- ### 📝 Commits (5) - [`69bf404`](https://github.com/documenso/documenso/commit/69bf404b324c949b147030c9b4059dcc6e6296a0) feat: select signature color - [`a301dd3`](https://github.com/documenso/documenso/commit/a301dd345f80023913deba045602e778b4aa8714) feat: add colors - [`80d2d07`](https://github.com/documenso/documenso/commit/80d2d0703a71095e310bccef38322b979b769f7a) fix: select element width - [`51afe95`](https://github.com/documenso/documenso/commit/51afe95780fe2cf367dfc5402373a0e2bb684a3b) chore: merge main - [`a730acc`](https://github.com/documenso/documenso/commit/a730acc76ad19a4877a148e7efc778cef9b88e1d) chore: reverted merge ### 📊 Changes **68 files changed** (+1064 additions, -2805 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/cache-build/action.yml` (+2 -2) 📝 `.github/actions/node-install/action.yml` (+1 -1) 📝 `README.md` (+0 -4) 📝 `apps/documentation/package.json` (+2 -2) 📝 `apps/documentation/pages/developers/_meta.json` (+1 -2) ➖ `apps/documentation/pages/developers/embedding/index.mdx` (+0 -131) ➖ `apps/documentation/pages/developers/embedding/preact.mdx` (+0 -77) ➖ `apps/documentation/pages/developers/embedding/react.mdx` (+0 -77) ➖ `apps/documentation/pages/developers/embedding/solid.mdx` (+0 -77) ➖ `apps/documentation/pages/developers/embedding/svelte.mdx` (+0 -79) ➖ `apps/documentation/pages/developers/embedding/vue.mdx` (+0 -79) 📝 `apps/documentation/pages/developers/local-development/_meta.json` (+2 -3) ➖ `apps/documentation/pages/developers/local-development/translations.mdx` (+0 -128) 📝 `apps/documentation/pages/users/signing-documents/fields.mdx` (+42 -42) 📝 `apps/documentation/pages/users/signing-documents/index.mdx` (+12 -12) 📝 `apps/documentation/pages/users/templates.mdx` (+8 -8) ➖ `apps/documentation/public/embedding/copy-recipient-token.png` (+0 -0) ➖ `apps/documentation/public/embedding/enable-direct-link.png` (+0 -0) ➖ `apps/documentation/public/embedding/team-templates.png` (+0 -0) 📝 `apps/marketing/package.json` (+17 -10) _...and 48 more files_ </details> ### 📄 Description ## Description Allow users to select a colour for the signature. The allowed colours are black, white, red, blue, and green. https://github.com/user-attachments/assets/82b97a16-45e2-4f5d-b938-27d27a59b558 ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Summary by CodeRabbit - **New Features** - Introduced a color selection feature in the SignaturePad, allowing users to choose between black, red, blue, and green for their signatures. - Added new translations for color names in both German and English localizations to enhance multilingual support. - **Bug Fixes** - Updated existing translations for "Clear Signature" to reflect changes in line numbers for improved accuracy. - **Documentation** - Enhanced localization documentation by expanding available translations for color options in the user interface.   ## Summary by CodeRabbit - **New Features** - Introduced color selection for signatures in the SignaturePad component, allowing users to choose from five colors: black, white, red, blue, and green. - Added new translations for color names in both German and English localizations, enhancing multilingual support. - **Bug Fixes** - Updated existing translations for "Clear Signature" to reflect changes in line numbers. - **Documentation** - Removed outdated deployment instructions for Elestio from the README. - Updated image paths in various documentation files to ensure correct referencing.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:46 +03:00

[PR #1560] [CLOSED] fix: refactor api routes #1716

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1560

No description provided.

Rows
Columns