starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1325] [MERGED] feat: allow recipient to select signature color #1559

New issue

Closed

opened 2026-02-26 19:33:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1325
Author: @catalinpit
Created: 9/5/2024
Status: ✅ Merged
Merged: 9/6/2024
Merged by: @Mythie

Base: main ← Head: feat/choose-signature-color

📝 Commits (3)

8f551c3 feat: allow recipient to select signature color
4480d96 chore: update styling
c8e8246 chore: extract translations

📊 Changes

7 files changed (+101 additions, -7 deletions)

View changed files

📝 packages/lib/translations/de/common.po (+21 -1)
📝 packages/lib/translations/de/marketing.js (+1 -1)
📝 packages/lib/translations/de/web.js (+1 -1)
📝 packages/lib/translations/en/common.po (+21 -1)
📝 packages/lib/translations/en/marketing.js (+1 -1)
📝 packages/lib/translations/en/web.js (+1 -1)
📝 packages/ui/primitives/signature-pad/signature-pad.tsx (+55 -1)

📄 Description

Description

Allow users to select a colour for the signature. The allowed colours are black, white, red, blue, and green.

https://github.com/user-attachments/assets/82b97a16-45e2-4f5d-b938-27d27a59b558

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Introduced a color selection feature in the SignaturePad, allowing users to choose between black, red, blue, and green for their signatures.
- Added new translations for color names in both German and English localizations to enhance multilingual support.
Bug Fixes
- Updated existing translations for "Clear Signature" to reflect changes in line numbers for improved accuracy.
Documentation
- Enhanced localization documentation by expanding available translations for color options in the user interface.

Summary by CodeRabbit

New Features
- Introduced color selection for signatures in the SignaturePad component, allowing users to choose from four colors: black, red, blue, and green.
- Added new translations for color names in both German and English localizations, enhancing multilingual support.
Bug Fixes
- Updated existing translations for "Clear Signature" to reflect changes in line numbers.
Documentation
- Improved formatting of JSON structures in localization files for better readability and maintainability.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1325 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 9/5/2024 **Status:** ✅ Merged **Merged:** 9/6/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/choose-signature-color` --- ### 📝 Commits (3) - [`8f551c3`](https://github.com/documenso/documenso/commit/8f551c342bb344ffd2c8b67d203a4e36be06ba9c) feat: allow recipient to select signature color - [`4480d96`](https://github.com/documenso/documenso/commit/4480d9699272947d11128a3292fad5cdb90e2282) chore: update styling - [`c8e8246`](https://github.com/documenso/documenso/commit/c8e824652d6b3921ef32d1280813704324a7400f) chore: extract translations ### 📊 Changes **7 files changed** (+101 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/translations/de/common.po` (+21 -1) 📝 `packages/lib/translations/de/marketing.js` (+1 -1) 📝 `packages/lib/translations/de/web.js` (+1 -1) 📝 `packages/lib/translations/en/common.po` (+21 -1) 📝 `packages/lib/translations/en/marketing.js` (+1 -1) 📝 `packages/lib/translations/en/web.js` (+1 -1) 📝 `packages/ui/primitives/signature-pad/signature-pad.tsx` (+55 -1) </details> ### 📄 Description ## Description Allow users to select a colour for the signature. The allowed colours are black, white, red, blue, and green. https://github.com/user-attachments/assets/82b97a16-45e2-4f5d-b938-27d27a59b558 ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Summary by CodeRabbit - **New Features** - Introduced a color selection feature in the SignaturePad, allowing users to choose between black, red, blue, and green for their signatures. - Added new translations for color names in both German and English localizations to enhance multilingual support. - **Bug Fixes** - Updated existing translations for "Clear Signature" to reflect changes in line numbers for improved accuracy. - **Documentation** - Enhanced localization documentation by expanding available translations for color options in the user interface.   ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced color selection for signatures in the SignaturePad component, allowing users to choose from four colors: black, red, blue, and green. - Added new translations for color names in both German and English localizations, enhancing multilingual support. - **Bug Fixes** - Updated existing translations for "Clear Signature" to reflect changes in line numbers. - **Documentation** - Improved formatting of JSON structures in localization files for better readability and maintainability.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:45 +03:00

[PR #1559] [MERGED] fix: default to user timezone #1715

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1559

No description provided.

Rows
Columns