[PR #1323] [MERGED] fix: show the existing field meta when editing a template fields #1558

New issue

Closed

opened 2026-02-26 19:33:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1323
Author: @Etrenak
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/5/2024
Merged by: @Mythie

Base: main ← Head: fix/1259-field-meta-in-edit-template

📝 Commits (1)

4fff3ad fix: show the existing field meta when editing a template fields

📊 Changes

3 files changed (+29 additions, -28 deletions)

View changed files

📝 packages/lib/translations/de/common.po (+14 -14)
📝 packages/lib/translations/en/common.po (+14 -14)
📝 packages/ui/primitives/template-flow/add-template-fields.tsx (+1 -0)

📄 Description

Description

Fixes #1259. I literally just used the exact same line of code than from the document page so it is consistent.

The bug is extremely frustrating because if you make change to the fields meta on the template and refresh the page, you can't see field meta (label, default value, required), and neither do your co-workers.

Of course, I tested the change and it now displays correctly the existing field meta on the template page.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Enhanced the AddTemplateFieldsFormPartial component by adding a fieldMeta property for improved metadata handling.
Bug Fixes
- Updated translation mappings to ensure accuracy following changes in the source files, maintaining the integrity of the translation system.
Chores
- Incremented line numbers in translation files to reflect changes in the corresponding source code structure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1323 **Author:** [@Etrenak](https://github.com/Etrenak) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/5/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/1259-field-meta-in-edit-template` --- ### 📝 Commits (1) - [`4fff3ad`](https://github.com/documenso/documenso/commit/4fff3ad3a0fd6ab89544de105a5cf7a1bce4ddbb) fix: show the existing field meta when editing a template fields ### 📊 Changes **3 files changed** (+29 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/translations/de/common.po` (+14 -14) 📝 `packages/lib/translations/en/common.po` (+14 -14) 📝 `packages/ui/primitives/template-flow/add-template-fields.tsx` (+1 -0) </details> ### 📄 Description ## Description Fixes #1259. I literally just used the exact same line of code than from the document page so it is consistent. The bug is extremely frustrating because if you make change to the fields meta on the template and refresh the page, you can't see field meta (label, default value, required), and neither do your co-workers. Of course, I tested the change and it now displays correctly the existing field meta on the template page. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced the AddTemplateFieldsFormPartial component by adding a fieldMeta property for improved metadata handling. - **Bug Fixes** - Updated translation mappings to ensure accuracy following changes in the source files, maintaining the integrity of the translation system. - **Chores** - Incremented line numbers in translation files to reflect changes in the corresponding source code structure.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:46 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1558

No description provided.

Rows
Columns