starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1321] [MERGED] fix: refactor dates #1556

New issue

Closed

opened 2026-02-26 19:33:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1321
Author: @dguyen
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @dguyen

Base: main ← Head: fix/refactor-dates

📝 Commits (2)

3b32c74 fix: refactor dates
8e36510 chore: extract translations

📊 Changes

38 files changed (+562 additions, -701 deletions)

View changed files

📝 apps/marketing/src/app/layout.tsx (+5 -23)
📝 apps/marketing/src/middleware.ts (+2 -2)
📝 apps/web/src/app/(dashboard)/admin/documents/[id]/page.tsx (+4 -6)
📝 apps/web/src/app/(dashboard)/admin/documents/document-results.tsx (+3 -4)
📝 apps/web/src/app/(dashboard)/documents/[id]/document-page-view-information.tsx (+8 -17)
📝 apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-data-table.tsx (+3 -7)
📝 apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx (+3 -6)
📝 apps/web/src/app/(dashboard)/documents/data-table.tsx (+5 -10)
📝 apps/web/src/app/(dashboard)/settings/billing/page.tsx (+3 -5)
📝 apps/web/src/app/(dashboard)/settings/security/activity/user-security-activity-data-table.tsx (+2 -4)
📝 apps/web/src/app/(dashboard)/settings/tokens/page.tsx (+3 -6)
📝 apps/web/src/app/(dashboard)/settings/webhooks/page.tsx (+2 -6)
📝 apps/web/src/app/(dashboard)/templates/data-table-templates.tsx (+9 -10)
📝 apps/web/src/app/(internal)/%5F%5Fhtmltopdf/audit-log/data-table.tsx (+4 -3)
📝 apps/web/src/app/(internal)/%5F%5Fhtmltopdf/audit-log/page.tsx (+9 -6)
📝 apps/web/src/app/(internal)/%5F%5Fhtmltopdf/certificate/page.tsx (+17 -28)
📝 apps/web/src/app/(teams)/t/[teamUrl]/settings/tokens/page.tsx (+9 -6)
📝 apps/web/src/app/(teams)/t/[teamUrl]/settings/webhooks/page.tsx (+2 -6)
📝 apps/web/src/app/layout.tsx (+17 -46)
📝 apps/web/src/components/(teams)/tables/current-user-teams-data-table.tsx (+2 -4)

...and 18 more files

📄 Description

Description

Refactor the current date formatting system to utilize Lingui.

Changes Made

Remove redundant LocaleData component with Lingui dates

Important notes

For the internal pages for certificates, default to en-US to format any dates.

Summary by CodeRabbit

New Features
- Enhanced internationalization support across various components by utilizing the i18n object for date formatting.
- Streamlined locale management by removing cookie-based language handling and adopting a more centralized approach.
Bug Fixes
- Improved date formatting consistency by replacing the LocaleDate component with direct calls to i18n.date() in multiple components.
Documentation
- Updated localization strings in the web.po files to reflect recent changes in the source code structure.
Chores
- Minor formatting adjustments and code organization improvements across various files to enhance readability and maintainability.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1321 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/refactor-dates` --- ### 📝 Commits (2) - [`3b32c74`](https://github.com/documenso/documenso/commit/3b32c74b51d6241e6dabe85a182f22d4c6afcfea) fix: refactor dates - [`8e36510`](https://github.com/documenso/documenso/commit/8e36510a1e9fbfca3cf29c4bbc622e6fb6146a3d) chore: extract translations ### 📊 Changes **38 files changed** (+562 additions, -701 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/src/app/layout.tsx` (+5 -23) 📝 `apps/marketing/src/middleware.ts` (+2 -2) 📝 `apps/web/src/app/(dashboard)/admin/documents/[id]/page.tsx` (+4 -6) 📝 `apps/web/src/app/(dashboard)/admin/documents/document-results.tsx` (+3 -4) 📝 `apps/web/src/app/(dashboard)/documents/[id]/document-page-view-information.tsx` (+8 -17) 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-data-table.tsx` (+3 -7) 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx` (+3 -6) 📝 `apps/web/src/app/(dashboard)/documents/data-table.tsx` (+5 -10) 📝 `apps/web/src/app/(dashboard)/settings/billing/page.tsx` (+3 -5) 📝 `apps/web/src/app/(dashboard)/settings/security/activity/user-security-activity-data-table.tsx` (+2 -4) 📝 `apps/web/src/app/(dashboard)/settings/tokens/page.tsx` (+3 -6) 📝 `apps/web/src/app/(dashboard)/settings/webhooks/page.tsx` (+2 -6) 📝 `apps/web/src/app/(dashboard)/templates/data-table-templates.tsx` (+9 -10) 📝 `apps/web/src/app/(internal)/%5F%5Fhtmltopdf/audit-log/data-table.tsx` (+4 -3) 📝 `apps/web/src/app/(internal)/%5F%5Fhtmltopdf/audit-log/page.tsx` (+9 -6) 📝 `apps/web/src/app/(internal)/%5F%5Fhtmltopdf/certificate/page.tsx` (+17 -28) 📝 `apps/web/src/app/(teams)/t/[teamUrl]/settings/tokens/page.tsx` (+9 -6) 📝 `apps/web/src/app/(teams)/t/[teamUrl]/settings/webhooks/page.tsx` (+2 -6) 📝 `apps/web/src/app/layout.tsx` (+17 -46) 📝 `apps/web/src/components/(teams)/tables/current-user-teams-data-table.tsx` (+2 -4) _...and 18 more files_ </details> ### 📄 Description ## Description Refactor the current date formatting system to utilize Lingui. ## Changes Made - Remove redundant `LocaleData` component with Lingui dates ## Important notes For the internal pages for certificates, default to en-US to format any dates.  ## Summary by CodeRabbit - **New Features** - Enhanced internationalization support across various components by utilizing the `i18n` object for date formatting. - Streamlined locale management by removing cookie-based language handling and adopting a more centralized approach. - **Bug Fixes** - Improved date formatting consistency by replacing the `LocaleDate` component with direct calls to `i18n.date()` in multiple components. - **Documentation** - Updated localization strings in the `web.po` files to reflect recent changes in the source code structure. - **Chores** - Minor formatting adjustments and code organization improvements across various files to enhance readability and maintainability.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:45 +03:00

[PR #1556] [MERGED] fix: tests #1714

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1556

No description provided.

Rows
Columns