starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1313] [CLOSED] feat: add TypedSQL to Documenso #1549

New issue

Closed

opened 2026-02-26 19:33:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1313
Author: @jharrell
Created: 8/28/2024
Status: ❌ Closed

Base: main ← Head: feat/typedsql

📝 Commits (10+)

8690912 chore: extract translations
48ef8e7 feat(prisma): add typedsql
c3907ab fix(prisma): try more things
f1a8628 Merge branch 'main' into feat/typedsql
090e2e1 Update marketing.js
0c611cc fix(prisma): re-add kysely if needed in the future
c3019d6 fix(prisma): quick formatting tweaks
b30bdaf Merge branch 'main' into feat/typedsql
e64e58e Merge branch 'main' into feat/typedsql
23730a6 Merge branch 'main' into feat/typedsql

📊 Changes

17 files changed (+340 additions, -141 deletions)

View changed files

📝 .github/actions/node-install/action.yml (+1 -1)
📝 package-lock.json (+268 -54)
📝 package.json (+2 -1)
📝 packages/lib/package.json (+1 -1)
📝 packages/lib/server-only/admin/get-users-stats.ts (+2 -17)
📝 packages/lib/server-only/user/get-monthly-completed-document.ts (+2 -20)
📝 packages/lib/server-only/user/get-signer-conversion.ts (+2 -19)
📝 packages/lib/server-only/user/get-user-monthly-growth.ts (+2 -18)
📝 packages/lib/translations/de/marketing.js (+1 -1)
📝 packages/prisma/index.ts (+13 -0)
📝 packages/prisma/package.json (+7 -6)
📝 packages/prisma/schema.prisma (+2 -1)
➕ packages/prisma/sql/completedDocumentsMonthly.sql (+9 -0)
➕ packages/prisma/sql/signerConversionMonthly.sql (+10 -0)
➕ packages/prisma/sql/userMonthlyGrowth.sql (+8 -0)
➕ packages/prisma/sql/userWithSignedDocumentMonthlyGrowth.sql (+8 -0)
📝 scripts/vercel.sh (+2 -2)

📄 Description

name: TypedSQL in Documenso
about: Add new TypedSQL feature from Prisma ORM 5.19.0 to Documenso

Description

Hello again! Now that we're released, I'd like to see if we can get TypedSQL into Documenso proper. I realize this PR is a bit more dramatic than what you're probably looking for, I'm happy to scale back changes but just wanted to get this ported over sooner so more eyes can get a look.

Changes Made

moved calls from prisma generate to prisma generate --sql
transitioned raw queries and query builder usages to TypedSQL
...

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Introduced new SQL generation commands to enhance database management.
- Added SQL queries for monthly document completion, user sign-up analysis, and user growth tracking.
Improvements
- Streamlined the build process with updated scripts and dependency management.
Localization
- Updated German localization strings to improve user experience for German-speaking users.
- Modified marketing localization for better clarity in German.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1313 **Author:** [@jharrell](https://github.com/jharrell) **Created:** 8/28/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/typedsql` --- ### 📝 Commits (10+) - [`8690912`](https://github.com/documenso/documenso/commit/8690912a184cdfc1e613e3cd53f2a87de2aaf2a5) chore: extract translations - [`48ef8e7`](https://github.com/documenso/documenso/commit/48ef8e78a8ef591062064ac7ec5135e608b11bd5) feat(prisma): add typedsql - [`c3907ab`](https://github.com/documenso/documenso/commit/c3907ab5f4cc08c25258d5b1dba84c8049cc2059) fix(prisma): try more things - [`f1a8628`](https://github.com/documenso/documenso/commit/f1a86283b5f83287f3ccc7380d9d4d2a8c517de8) Merge branch 'main' into feat/typedsql - [`090e2e1`](https://github.com/documenso/documenso/commit/090e2e171312988df355c062cabb3360f063d761) Update marketing.js - [`0c611cc`](https://github.com/documenso/documenso/commit/0c611ccacc5e4e2faf67f245e84abd5d4ef78c07) fix(prisma): re-add kysely if needed in the future - [`c3019d6`](https://github.com/documenso/documenso/commit/c3019d6f83d5629c193dbfee229a4b1b3ee39740) fix(prisma): quick formatting tweaks - [`b30bdaf`](https://github.com/documenso/documenso/commit/b30bdaf2991cb247cbec00e0f3a887c58c102215) Merge branch 'main' into feat/typedsql - [`e64e58e`](https://github.com/documenso/documenso/commit/e64e58ea8b3a7dc5fbad3c2e69bebf6d4eae8566) Merge branch 'main' into feat/typedsql - [`23730a6`](https://github.com/documenso/documenso/commit/23730a6d1342548e48fdb3fcdf44466a6adb6734) Merge branch 'main' into feat/typedsql ### 📊 Changes **17 files changed** (+340 additions, -141 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/node-install/action.yml` (+1 -1) 📝 `package-lock.json` (+268 -54) 📝 `package.json` (+2 -1) 📝 `packages/lib/package.json` (+1 -1) 📝 `packages/lib/server-only/admin/get-users-stats.ts` (+2 -17) 📝 `packages/lib/server-only/user/get-monthly-completed-document.ts` (+2 -20) 📝 `packages/lib/server-only/user/get-signer-conversion.ts` (+2 -19) 📝 `packages/lib/server-only/user/get-user-monthly-growth.ts` (+2 -18) 📝 `packages/lib/translations/de/marketing.js` (+1 -1) 📝 `packages/prisma/index.ts` (+13 -0) 📝 `packages/prisma/package.json` (+7 -6) 📝 `packages/prisma/schema.prisma` (+2 -1) ➕ `packages/prisma/sql/completedDocumentsMonthly.sql` (+9 -0) ➕ `packages/prisma/sql/signerConversionMonthly.sql` (+10 -0) ➕ `packages/prisma/sql/userMonthlyGrowth.sql` (+8 -0) ➕ `packages/prisma/sql/userWithSignedDocumentMonthlyGrowth.sql` (+8 -0) 📝 `scripts/vercel.sh` (+2 -2) </details> ### 📄 Description --- name: TypedSQL in Documenso about: Add new TypedSQL feature from Prisma ORM 5.19.0 to Documenso --- ## Description Hello again! Now that we're released, I'd like to see if we can get TypedSQL into Documenso proper. I realize this PR is a bit more dramatic than what you're probably looking for, I'm happy to scale back changes but just wanted to get this ported over sooner so more eyes can get a look. ## Changes Made   - moved calls from `prisma generate` to `prisma generate --sql` - transitioned raw queries and query builder usages to TypedSQL - ... ## Checklist   - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Introduced new SQL generation commands to enhance database management. - Added SQL queries for monthly document completion, user sign-up analysis, and user growth tracking. - **Improvements** - Streamlined the build process with updated scripts and dependency management. - **Localization** - Updated German localization strings to improve user experience for German-speaking users. - Modified marketing localization for better clarity in German.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:44 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:43 +03:00

[PR #1549] [MERGED] feat: notify owner when a recipient signs #1709

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1549

No description provided.

Rows
Columns