starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 06:15:58 +03:00

[PR #1298] [MERGED] feat: add and use NEXT_PRIVATE_INTERNAL_WEBAPP_URL #1539

New issue

Closed

opened 2026-02-26 19:33:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1298
Author: @david-loe
Created: 8/22/2024
Status: ✅ Merged
Merged: 9/6/2024
Merged by: @Mythie

Base: main ← Head: main

📝 Commits (1)

ffc31e3 add and use NEXT_PRIVATE_INTERNAL_WEBAPP_URL

📊 Changes

12 files changed (+25 additions, -7 deletions)

View changed files

📝 .env.example (+2 -0)
📝 apps/marketing/process-env.d.ts (+2 -1)
📝 apps/web/process-env.d.ts (+1 -0)
📝 docker/README.md (+1 -0)
📝 docker/production/compose.yml (+1 -0)
📝 packages/lib/constants/app.ts (+1 -0)
📝 packages/lib/jobs/client/local.ts (+2 -2)
📝 packages/lib/server-only/feature-flags/all.ts (+5 -1)
📝 packages/lib/server-only/feature-flags/get.ts (+5 -1)
📝 packages/lib/server-only/webhooks/trigger/trigger-webhook.ts (+2 -2)
📝 render.yaml (+2 -0)
📝 turbo.json (+1 -0)

📄 Description

Description

Introduces NEXT_PRIVATE_INTERNAL_WEBAPP_URL used for requesting the app by itself (backend) [e.g. for background jobs]

Fixes #1289

Changes Made

added NEXT_PRIVATE_INTERNAL_WEBAPP_URL to .env.example, compose.yml, render.yaml, turbo.json
NEXT_PRIVATE_INTERNAL_WEBAPP_URL is set to NEXT_PUBLIC_WEBAPP_URL when null or undefined
made background jobs local and trigger-webhooks use NEXT_PRIVATE_INTERNAL_WEBAPP_URL
added NEXT_PRIVATE_INTERNAL_WEBAPP_URL to Access-Control-Allow-Origin

Checklist

I have tested these changes locally and they work as expected.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.

Summary by CodeRabbit

New Features
- Introduced a new environment variable, NEXT_PRIVATE_INTERNAL_WEBAPP_URL, enhancing configuration options for internal communication within the application.
Improvements
- Updated internal references and functionality to utilize the new private internal web application URL, improving security and accessibility.
Documentation
- Added details about the new environment variable to Docker configurations and README files, aiding in setup and deployment.
Refactor
- Modified existing code to replace public web application URLs with the new private URL for internal processes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1298 **Author:** [@david-loe](https://github.com/david-loe) **Created:** 8/22/2024 **Status:** ✅ Merged **Merged:** 9/6/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`ffc31e3`](https://github.com/documenso/documenso/commit/ffc31e3789e5870332630a79dd5c802bab311534) add and use NEXT_PRIVATE_INTERNAL_WEBAPP_URL ### 📊 Changes **12 files changed** (+25 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+2 -0) 📝 `apps/marketing/process-env.d.ts` (+2 -1) 📝 `apps/web/process-env.d.ts` (+1 -0) 📝 `docker/README.md` (+1 -0) 📝 `docker/production/compose.yml` (+1 -0) 📝 `packages/lib/constants/app.ts` (+1 -0) 📝 `packages/lib/jobs/client/local.ts` (+2 -2) 📝 `packages/lib/server-only/feature-flags/all.ts` (+5 -1) 📝 `packages/lib/server-only/feature-flags/get.ts` (+5 -1) 📝 `packages/lib/server-only/webhooks/trigger/trigger-webhook.ts` (+2 -2) 📝 `render.yaml` (+2 -0) 📝 `turbo.json` (+1 -0) </details> ### 📄 Description ## Description Introduces `NEXT_PRIVATE_INTERNAL_WEBAPP_URL` used for requesting the app by itself (backend) [e.g. for background jobs] ## Related Issue Fixes #1289 ## Changes Made - added `NEXT_PRIVATE_INTERNAL_WEBAPP_URL` to `.env.example`, `compose.yml`, `render.yaml`, `turbo.json` - `NEXT_PRIVATE_INTERNAL_WEBAPP_URL` is set to `NEXT_PUBLIC_WEBAPP_URL` when `null` or `undefined` - made background jobs local and trigger-webhooks use `NEXT_PRIVATE_INTERNAL_WEBAPP_URL` - added `NEXT_PRIVATE_INTERNAL_WEBAPP_URL` to `Access-Control-Allow-Origin` ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines.  ## Summary by CodeRabbit - **New Features** - Introduced a new environment variable, `NEXT_PRIVATE_INTERNAL_WEBAPP_URL`, enhancing configuration options for internal communication within the application. - **Improvements** - Updated internal references and functionality to utilize the new private internal web application URL, improving security and accessibility. - **Documentation** - Added details about the new environment variable to Docker configurations and README files, aiding in setup and deployment. - **Refactor** - Modified existing code to replace public web application URLs with the new private URL for internal processes.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:41 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:42 +03:00

[PR #1539] [MERGED] feat: make enterprise billing dynamic #1702

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1539

No description provided.

Rows
Columns