starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 06:15:58 +03:00

[PR #1277] [MERGED] fix: changed the default file path for NEXT_PRIVATE_SIGNING_LOCAL_FIL… #1527

New issue

Closed

opened 2026-02-26 19:33:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1277
Author: @binary-amigo
Created: 8/9/2024
Status: ✅ Merged
Merged: 9/6/2024
Merged by: @Mythie

Base: main ← Head: fix/file-path

📝 Commits (5)

c96b8e1 fix: changed the default file path for NEXT_PRIVATE_SIGNING_LOCAL_FILE_PATH
68c1cf2 fix: add fallback for local development
5cc2d52 Merge branch 'main' into fix/file-path
ef2096e Merge branch 'main' into fix/file-path
6339a8c chore: update ci

📊 Changes

2 files changed (+15 additions, -3 deletions)

View changed files

📝 .github/workflows/e2e-tests.yml (+3 -0)
📝 packages/signing/transports/local-cert.ts (+12 -3)

📄 Description

name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Fixes #1625

Changes Made

Changed the default value of NEXT_PRIVATE_SIGNING_LOCAL_FILE_PATH env variable

Change 1
Replaced './example/cert.p12' with '/opt/documenso/cert.p12' in local-cert.ts

Testing Performed

Tested by leaving the NEXT_PRIVATE_SIGNING_LOCAL_FILE_PATH empty and running project. Project run successfully

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Summary by CodeRabbit

New Features
- Updated the default file path for reading local certificates to improve deployment consistency.
Bug Fixes
- Ensured the certificate loading function operates correctly with the new file path without altering its core functionality.
Chores
- Added environment variable configuration for improved Playwright test execution.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1277 **Author:** [@binary-amigo](https://github.com/binary-amigo) **Created:** 8/9/2024 **Status:** ✅ Merged **Merged:** 9/6/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/file-path` --- ### 📝 Commits (5) - [`c96b8e1`](https://github.com/documenso/documenso/commit/c96b8e168b4fecf65ba6480c3636aa456f6673be) fix: changed the default file path for NEXT_PRIVATE_SIGNING_LOCAL_FILE_PATH - [`68c1cf2`](https://github.com/documenso/documenso/commit/68c1cf2511f7736b424038bd1b1fa0a2e59c8fa8) fix: add fallback for local development - [`5cc2d52`](https://github.com/documenso/documenso/commit/5cc2d5274eaaee69e5883fccee5f3b4a77ea51f8) Merge branch 'main' into fix/file-path - [`ef2096e`](https://github.com/documenso/documenso/commit/ef2096e983f7f48e9ea159f688afe40ba57c0b96) Merge branch 'main' into fix/file-path - [`6339a8c`](https://github.com/documenso/documenso/commit/6339a8cbe98e52b4a89c0a0d0dd83f8741384b32) chore: update ci ### 📊 Changes **2 files changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/e2e-tests.yml` (+3 -0) 📝 `packages/signing/transports/local-cert.ts` (+12 -3) </details> ### 📄 Description --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description ## Related Issue Fixes #1625 ## Changes Made Changed the default value of NEXT_PRIVATE_SIGNING_LOCAL_FILE_PATH env variable - Change 1 Replaced './example/cert.p12' with '/opt/documenso/cert.p12' in local-cert.ts ## Testing Performed Tested by leaving the NEXT_PRIVATE_SIGNING_LOCAL_FILE_PATH empty and running project. Project run successfully ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes  ## Summary by CodeRabbit - **New Features** - Updated the default file path for reading local certificates to improve deployment consistency. - **Bug Fixes** - Ensured the certificate loading function operates correctly with the new file path without altering its core functionality. - **Chores** - Added environment variable configuration for improved Playwright test execution.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:38 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:39 +03:00

[PR #1527] [CLOSED] chore: update deps #1691

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1527

No description provided.

Rows
Columns