[PR #1273] [MERGED] fix: radio and checkbox fields issues with empty values #1524

Closed
opened 2026-02-26 19:33:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1273
Author: @catalinpit
Created: 8/8/2024
Status: Merged
Merged: 8/9/2024
Merged by: @Mythie

Base: mainHead: fix/radio-checkbox-fields-empty-values


📝 Commits (1)

  • ce40632 fix: radio and checkbox fields issues with empty values

📊 Changes

1 file changed (+12 additions, -2 deletions)

View changed files

📝 packages/lib/server-only/pdf/insert-field-in-pdf.ts (+12 -2)

📄 Description

Before: Checkbox field on signed document

CleanShot 2024-08-08 at 11 15 40@2x

Before: Radio field on signed document

CleanShot 2024-08-08 at 09 09 41@2x

After: Checkbox field on signed document

CleanShot 2024-08-08 at 11 40 29@2x

After: Radio field on signed document

CleanShot 2024-08-08 at 14 56 40@2x

Summary by CodeRabbit

  • New Features
    • Improved handling of checkbox and radio field metadata in PDF forms, ensuring default values for empty fields.
  • Bug Fixes
    • Enhanced robustness against null or undefined values in PDF metadata, improving overall reliability.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1273 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 8/8/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/radio-checkbox-fields-empty-values` --- ### 📝 Commits (1) - [`ce40632`](https://github.com/documenso/documenso/commit/ce40632b65e64a00c0180fc06713111ba523da2e) fix: radio and checkbox fields issues with empty values ### 📊 Changes **1 file changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/pdf/insert-field-in-pdf.ts` (+12 -2) </details> ### 📄 Description ## Before: Checkbox field on signed document ![CleanShot 2024-08-08 at 11 15 40@2x](https://github.com/user-attachments/assets/f8783846-52ae-4a6a-b78e-d151c79b7a0d) ## Before: Radio field on signed document ![CleanShot 2024-08-08 at 09 09 41@2x](https://github.com/user-attachments/assets/8b2e1b69-29e2-484d-8473-5d79e4f28ba5) ## After: Checkbox field on signed document ![CleanShot 2024-08-08 at 11 40 29@2x](https://github.com/user-attachments/assets/02a9c34e-5225-4bbe-a701-103a9ab1b8ee) ## After: Radio field on signed document ![CleanShot 2024-08-08 at 14 56 40@2x](https://github.com/user-attachments/assets/9d99a031-f91a-412f-b3be-c328911a68b9) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved handling of checkbox and radio field metadata in PDF forms, ensuring default values for empty fields. - **Bug Fixes** - Enhanced robustness against null or undefined values in PDF metadata, improving overall reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1524
No description provided.